pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Melanie Plageman <melanieplageman@gmail.com>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Minor test fixes in 035_standby_logical_decoding.pl
Date: Mon, 04 Aug 2025 19:09:42 +0000
Message-ID: <E1uj0Z3-000kZH-20@gemulon.postgresql.org> (raw)

Minor test fixes in 035_standby_logical_decoding.pl

Import usleep, which, due to an oversight in oversight in commit
48796a98d5ae was used but not imported.

Correct the comparison string used in two logfile checks. Previously, it
was incorrect and thus the test could never have failed.

Also wordsmith a comment to make it clear when hot_standby_feedback is
meant to be on during the test scenarios.

Reported-by: Melanie Plageman <melanieplageman@gmail.com>
Author: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Reviewed-by: Masahiko Sawada <sawada.mshk@gmail.com>
Discussion: https://postgr.es/m/flat/CAAKRu_YO2mEm%3DZWZKPjTMU%3DgW5Y83_KMi_1cr51JwavH0ctd7w%40mail.gmail.com
Backpatch-through: 16

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/6551a05d9cf8ea75c0db232b661dadd16e595854

Modified Files
--------------
src/test/recovery/t/035_standby_logical_decoding.pl | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)



view thread (4+ messages)  latest in thread

Message-ID: <E1uj0Z3-000kZH-20@gemulon.postgresql.org>
Permalink:  ../E1uj0Z3-000kZH-20@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1uj0Z3-000kZH-20@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: melanieplageman@gmail.com, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Minor test fixes in 035_standby_logical_decoding.pl
  In-Reply-To: <E1uj0Z3-000kZH-20@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox