pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Minor test fixes in 035_standby_logical_decoding.pl 4+ messages / 1 participants [nested] [flat]
* pgsql: Minor test fixes in 035_standby_logical_decoding.pl @ 2025-08-04 19:09 Melanie Plageman <melanieplageman@gmail.com> 0 siblings, 0 replies; 4+ messages in thread From: Melanie Plageman @ 2025-08-04 19:09 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Minor test fixes in 035_standby_logical_decoding.pl Import usleep, which, due to an oversight in oversight in commit 48796a98d5ae was used but not imported. Correct the comparison string used in two logfile checks. Previously, it was incorrect and thus the test could never have failed. Also wordsmith a comment to make it clear when hot_standby_feedback is meant to be on during the test scenarios. Reported-by: Melanie Plageman <melanieplageman@gmail.com> Author: Bertrand Drouvot <bertranddrouvot.pg@gmail.com> Reviewed-by: Masahiko Sawada <sawada.mshk@gmail.com> Discussion: https://postgr.es/m/flat/CAAKRu_YO2mEm%3DZWZKPjTMU%3DgW5Y83_KMi_1cr51JwavH0ctd7w%40mail.gmail.com Backpatch-through: 16 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/6551a05d9cf8ea75c0db232b661dadd16e595854 Modified Files -------------- src/test/recovery/t/035_standby_logical_decoding.pl | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Minor test fixes in 035_standby_logical_decoding.pl @ 2025-08-04 19:09 Melanie Plageman <melanieplageman@gmail.com> 0 siblings, 0 replies; 4+ messages in thread From: Melanie Plageman @ 2025-08-04 19:09 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Minor test fixes in 035_standby_logical_decoding.pl Import usleep, which, due to an oversight in oversight in commit 48796a98d5ae was used but not imported. Correct the comparison string used in two logfile checks. Previously, it was incorrect and thus the test could never have failed. Also wordsmith a comment to make it clear when hot_standby_feedback is meant to be on during the test scenarios. Reported-by: Melanie Plageman <melanieplageman@gmail.com> Author: Bertrand Drouvot <bertranddrouvot.pg@gmail.com> Reviewed-by: Masahiko Sawada <sawada.mshk@gmail.com> Discussion: https://postgr.es/m/flat/CAAKRu_YO2mEm%3DZWZKPjTMU%3DgW5Y83_KMi_1cr51JwavH0ctd7w%40mail.gmail.com Backpatch-through: 16 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/0e6b791846415ecff3df0e463a201fff8da7360b Modified Files -------------- src/test/recovery/t/035_standby_logical_decoding.pl | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Minor test fixes in 035_standby_logical_decoding.pl @ 2025-08-04 19:09 Melanie Plageman <melanieplageman@gmail.com> 0 siblings, 0 replies; 4+ messages in thread From: Melanie Plageman @ 2025-08-04 19:09 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Minor test fixes in 035_standby_logical_decoding.pl Import usleep, which, due to an oversight in oversight in commit 48796a98d5ae was used but not imported. Correct the comparison string used in two logfile checks. Previously, it was incorrect and thus the test could never have failed. Also wordsmith a comment to make it clear when hot_standby_feedback is meant to be on during the test scenarios. Reported-by: Melanie Plageman <melanieplageman@gmail.com> Author: Bertrand Drouvot <bertranddrouvot.pg@gmail.com> Reviewed-by: Masahiko Sawada <sawada.mshk@gmail.com> Discussion: https://postgr.es/m/flat/CAAKRu_YO2mEm%3DZWZKPjTMU%3DgW5Y83_KMi_1cr51JwavH0ctd7w%40mail.gmail.com Backpatch-through: 16 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/74dffe5c14ac0c2e1d993968e7baa7d0cb965e8c Modified Files -------------- src/test/recovery/t/035_standby_logical_decoding.pl | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Minor test fixes in 035_standby_logical_decoding.pl @ 2025-08-04 19:09 Melanie Plageman <melanieplageman@gmail.com> 0 siblings, 0 replies; 4+ messages in thread From: Melanie Plageman @ 2025-08-04 19:09 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Minor test fixes in 035_standby_logical_decoding.pl Import usleep, which, due to an oversight in oversight in commit 48796a98d5ae was used but not imported. Correct the comparison string used in two logfile checks. Previously, it was incorrect and thus the test could never have failed. Also wordsmith a comment to make it clear when hot_standby_feedback is meant to be on during the test scenarios. Reported-by: Melanie Plageman <melanieplageman@gmail.com> Author: Bertrand Drouvot <bertranddrouvot.pg@gmail.com> Reviewed-by: Masahiko Sawada <sawada.mshk@gmail.com> Discussion: https://postgr.es/m/flat/CAAKRu_YO2mEm%3DZWZKPjTMU%3DgW5Y83_KMi_1cr51JwavH0ctd7w%40mail.gmail.com Backpatch-through: 16 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/3c2c3f2ddb0f27062b73cea500f806e42f01db33 Modified Files -------------- src/test/recovery/t/035_standby_logical_decoding.pl | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2025-08-04 19:09 UTC | newest] Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-08-04 19:09 pgsql: Minor test fixes in 035_standby_logical_decoding.pl Melanie Plageman <melanieplageman@gmail.com> 2025-08-04 19:09 pgsql: Minor test fixes in 035_standby_logical_decoding.pl Melanie Plageman <melanieplageman@gmail.com> 2025-08-04 19:09 pgsql: Minor test fixes in 035_standby_logical_decoding.pl Melanie Plageman <melanieplageman@gmail.com> 2025-08-04 19:09 pgsql: Minor test fixes in 035_standby_logical_decoding.pl Melanie Plageman <melanieplageman@gmail.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox