pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Amit Kapila <akapila@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Throw ERROR when publish_generated_columns is specified without
Date: Tue, 05 Aug 2025 09:46:33 +0000
Message-ID: <E1ujEFd-000r0o-0g@gemulon.postgresql.org> (raw)

Throw ERROR when publish_generated_columns is specified without a value.

Previously, specifying the publication option 'publish_generated_columns'
without an explicit value would incorrectly default to 'stored', which is
not the intended behavior.

This patch fixes the issue by raising an ERROR when no value is provided
for 'publish_generated_columns', ensuring that users must explicitly
specify a valid option.

Author: Peter Smith <smithpb2250@gmail.com>
Reviewed-by: vignesh C <vignesh21@gmail.com>
Backpatch-through: 18, where it was introduced
Discussion: https://postgr.es/m/CAHut+PsCUCWiEKmB10DxhoPfXbF6jw5RD9ib2LuaQeA_XraW7w@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c9a5860f7a56cc639d6a73519b8b2a00d26d960c

Modified Files
--------------
src/backend/commands/publicationcmds.c    | 20 ++++++++++----------
src/test/regress/expected/publication.out | 15 ++++-----------
src/test/regress/sql/publication.sql      |  7 ++-----
3 files changed, 16 insertions(+), 26 deletions(-)



view thread (2+ messages)

Message-ID: <E1ujEFd-000r0o-0g@gemulon.postgresql.org>
Permalink:  ../E1ujEFd-000r0o-0g@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1ujEFd-000r0o-0g@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: akapila@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Throw ERROR when publish_generated_columns is specified without
  In-Reply-To: <E1ujEFd-000r0o-0g@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox