pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Remove INT64_HEX_FORMAT and UINT64_HEX_FORMAT
2+ messages / 1 participants
[nested] [flat]

* pgsql: Remove INT64_HEX_FORMAT and UINT64_HEX_FORMAT
@ 2025-08-06 09:09 Peter Eisentraut <peter@eisentraut.org>
  0 siblings, 0 replies; 2+ messages in thread

From: Peter Eisentraut @ 2025-08-06 09:09 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Remove INT64_HEX_FORMAT and UINT64_HEX_FORMAT

These were introduced (commit efdc7d74753) at the same time as we were
moving to using the standard inttypes.h format macros (commit
a0ed19e0a9e).  It doesn't seem useful to keep a new already-deprecated
interface like this with only a few users, so remove the new symbols
again and have the callers use PRIx64.

(Also, INT64_HEX_FORMAT was kind of a misnomer, since hex formats all
use unsigned types.)

Reviewed-by: Nathan Bossart <nathandbossart@gmail.com>
Reviewed-by: Thomas Munro <thomas.munro@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/0ac47b5d-e5ab-4cac-98a7-bdee0e2831e4%40eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/73d33be4dab7923bf879b82e8ea5fa214099b516

Modified Files
--------------
contrib/postgres_fdw/option.c                    | 2 +-
src/backend/utils/error/csvlog.c                 | 2 +-
src/backend/utils/error/elog.c                   | 4 ++--
src/backend/utils/error/jsonlog.c                | 2 +-
src/include/c.h                                  | 2 --
src/test/modules/test_radixtree/test_radixtree.c | 2 +-
6 files changed, 6 insertions(+), 8 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* pgsql: Remove INT64_HEX_FORMAT and UINT64_HEX_FORMAT
@ 2025-08-06 09:09 Peter Eisentraut <peter@eisentraut.org>
  0 siblings, 0 replies; 2+ messages in thread

From: Peter Eisentraut @ 2025-08-06 09:09 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Remove INT64_HEX_FORMAT and UINT64_HEX_FORMAT

These were introduced (commit efdc7d74753) at the same time as we were
moving to using the standard inttypes.h format macros (commit
a0ed19e0a9e).  It doesn't seem useful to keep a new already-deprecated
interface like this with only a few users, so remove the new symbols
again and have the callers use PRIx64.

(Also, INT64_HEX_FORMAT was kind of a misnomer, since hex formats all
use unsigned types.)

Reviewed-by: Nathan Bossart <nathandbossart@gmail.com>
Reviewed-by: Thomas Munro <thomas.munro@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/0ac47b5d-e5ab-4cac-98a7-bdee0e2831e4%40eisentraut.org

Branch
------
REL_18_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/ce13bb96fbcc3d3dd93b398fba2acf1e70a2080b

Modified Files
--------------
contrib/postgres_fdw/option.c                    | 2 +-
src/backend/utils/error/csvlog.c                 | 2 +-
src/backend/utils/error/elog.c                   | 4 ++--
src/backend/utils/error/jsonlog.c                | 2 +-
src/include/c.h                                  | 2 --
src/test/modules/test_radixtree/test_radixtree.c | 2 +-
6 files changed, 6 insertions(+), 8 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2025-08-06 09:09 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-08-06 09:09 pgsql: Remove INT64_HEX_FORMAT and UINT64_HEX_FORMAT Peter Eisentraut <peter@eisentraut.org>
2025-08-06 09:09 pgsql: Remove INT64_HEX_FORMAT and UINT64_HEX_FORMAT Peter Eisentraut <peter@eisentraut.org>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox