pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove INT64_HEX_FORMAT and UINT64_HEX_FORMAT
Date: Wed, 06 Aug 2025 09:09:13 +0000
Message-ID: <E1uja92-0011KF-2m@gemulon.postgresql.org> (raw)

Remove INT64_HEX_FORMAT and UINT64_HEX_FORMAT

These were introduced (commit efdc7d74753) at the same time as we were
moving to using the standard inttypes.h format macros (commit
a0ed19e0a9e).  It doesn't seem useful to keep a new already-deprecated
interface like this with only a few users, so remove the new symbols
again and have the callers use PRIx64.

(Also, INT64_HEX_FORMAT was kind of a misnomer, since hex formats all
use unsigned types.)

Reviewed-by: Nathan Bossart <nathandbossart@gmail.com>
Reviewed-by: Thomas Munro <thomas.munro@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/0ac47b5d-e5ab-4cac-98a7-bdee0e2831e4%40eisentraut.org

Branch
------
REL_18_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/ce13bb96fbcc3d3dd93b398fba2acf1e70a2080b

Modified Files
--------------
contrib/postgres_fdw/option.c                    | 2 +-
src/backend/utils/error/csvlog.c                 | 2 +-
src/backend/utils/error/elog.c                   | 4 ++--
src/backend/utils/error/jsonlog.c                | 2 +-
src/include/c.h                                  | 2 --
src/test/modules/test_radixtree/test_radixtree.c | 2 +-
6 files changed, 6 insertions(+), 8 deletions(-)



view thread (2+ messages)

Message-ID: <E1uja92-0011KF-2m@gemulon.postgresql.org>
Permalink:  ../E1uja92-0011KF-2m@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1uja92-0011KF-2m@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Remove INT64_HEX_FORMAT and UINT64_HEX_FORMAT
  In-Reply-To: <E1uja92-0011KF-2m@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox