pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix oversight in FindTriggerIncompatibleWithInheritance. 7+ messages / 1 participants [nested] [flat]
* pgsql: Fix oversight in FindTriggerIncompatibleWithInheritance. @ 2025-08-08 08:39 Etsuro Fujita <efujita@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Etsuro Fujita @ 2025-08-08 08:39 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix oversight in FindTriggerIncompatibleWithInheritance. This function is called from ATExecAttachPartition/ATExecAddInherit, which prevent tables with row-level triggers with transition tables from becoming partitions or inheritance children, to check if there is such a trigger on the given table, but failed to check if a found trigger is row-level, causing the caller functions to needlessly prevent a table with only a statement-level trigger with transition tables from becoming a partition or inheritance child. Repair. Oversight in commit 501ed02cf. Author: Etsuro Fujita <etsuro.fujita@gmail.com> Discussion: https://postgr.es/m/CAPmGK167mXzwzzmJ_0YZ3EZrbwiCxtM1vogH_8drqsE6PtxRYw%40mail.gmail.com Backpatch-through: 13 Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/f39a7f32aefcd424bdbe001f08718eaad5170d6b Modified Files -------------- src/backend/commands/trigger.c | 2 ++ src/test/regress/expected/triggers.out | 8 ++++++++ src/test/regress/sql/triggers.sql | 10 ++++++++++ 3 files changed, 20 insertions(+) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix oversight in FindTriggerIncompatibleWithInheritance. @ 2025-08-08 08:39 Etsuro Fujita <efujita@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Etsuro Fujita @ 2025-08-08 08:39 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix oversight in FindTriggerIncompatibleWithInheritance. This function is called from ATExecAttachPartition/ATExecAddInherit, which prevent tables with row-level triggers with transition tables from becoming partitions or inheritance children, to check if there is such a trigger on the given table, but failed to check if a found trigger is row-level, causing the caller functions to needlessly prevent a table with only a statement-level trigger with transition tables from becoming a partition or inheritance child. Repair. Oversight in commit 501ed02cf. Author: Etsuro Fujita <etsuro.fujita@gmail.com> Discussion: https://postgr.es/m/CAPmGK167mXzwzzmJ_0YZ3EZrbwiCxtM1vogH_8drqsE6PtxRYw%40mail.gmail.com Backpatch-through: 13 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/bba6a6fafc8ae5d2e364b713568068941a929d5f Modified Files -------------- src/backend/commands/trigger.c | 2 ++ src/test/regress/expected/triggers.out | 8 ++++++++ src/test/regress/sql/triggers.sql | 10 ++++++++++ 3 files changed, 20 insertions(+) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix oversight in FindTriggerIncompatibleWithInheritance. @ 2025-08-08 08:39 Etsuro Fujita <efujita@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Etsuro Fujita @ 2025-08-08 08:39 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix oversight in FindTriggerIncompatibleWithInheritance. This function is called from ATExecAttachPartition/ATExecAddInherit, which prevent tables with row-level triggers with transition tables from becoming partitions or inheritance children, to check if there is such a trigger on the given table, but failed to check if a found trigger is row-level, causing the caller functions to needlessly prevent a table with only a statement-level trigger with transition tables from becoming a partition or inheritance child. Repair. Oversight in commit 501ed02cf. Author: Etsuro Fujita <etsuro.fujita@gmail.com> Discussion: https://postgr.es/m/CAPmGK167mXzwzzmJ_0YZ3EZrbwiCxtM1vogH_8drqsE6PtxRYw%40mail.gmail.com Backpatch-through: 13 Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/73eb6afa13605d9bb619752180b739fd3c4ba168 Modified Files -------------- src/backend/commands/trigger.c | 2 ++ src/test/regress/expected/triggers.out | 8 ++++++++ src/test/regress/sql/triggers.sql | 10 ++++++++++ 3 files changed, 20 insertions(+) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix oversight in FindTriggerIncompatibleWithInheritance. @ 2025-08-08 08:39 Etsuro Fujita <efujita@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Etsuro Fujita @ 2025-08-08 08:39 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix oversight in FindTriggerIncompatibleWithInheritance. This function is called from ATExecAttachPartition/ATExecAddInherit, which prevent tables with row-level triggers with transition tables from becoming partitions or inheritance children, to check if there is such a trigger on the given table, but failed to check if a found trigger is row-level, causing the caller functions to needlessly prevent a table with only a statement-level trigger with transition tables from becoming a partition or inheritance child. Repair. Oversight in commit 501ed02cf. Author: Etsuro Fujita <etsuro.fujita@gmail.com> Discussion: https://postgr.es/m/CAPmGK167mXzwzzmJ_0YZ3EZrbwiCxtM1vogH_8drqsE6PtxRYw%40mail.gmail.com Backpatch-through: 13 Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/afdb4cde14948cdeb83701f457ecbfc4522c1a06 Modified Files -------------- src/backend/commands/trigger.c | 2 ++ src/test/regress/expected/triggers.out | 8 ++++++++ src/test/regress/sql/triggers.sql | 10 ++++++++++ 3 files changed, 20 insertions(+) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix oversight in FindTriggerIncompatibleWithInheritance. @ 2025-08-08 08:39 Etsuro Fujita <efujita@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Etsuro Fujita @ 2025-08-08 08:39 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix oversight in FindTriggerIncompatibleWithInheritance. This function is called from ATExecAttachPartition/ATExecAddInherit, which prevent tables with row-level triggers with transition tables from becoming partitions or inheritance children, to check if there is such a trigger on the given table, but failed to check if a found trigger is row-level, causing the caller functions to needlessly prevent a table with only a statement-level trigger with transition tables from becoming a partition or inheritance child. Repair. Oversight in commit 501ed02cf. Author: Etsuro Fujita <etsuro.fujita@gmail.com> Discussion: https://postgr.es/m/CAPmGK167mXzwzzmJ_0YZ3EZrbwiCxtM1vogH_8drqsE6PtxRYw%40mail.gmail.com Backpatch-through: 13 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/3863c6fb696cf57718483a3bf0abbf05e382abe1 Modified Files -------------- src/backend/commands/trigger.c | 2 ++ src/test/regress/expected/triggers.out | 8 ++++++++ src/test/regress/sql/triggers.sql | 10 ++++++++++ 3 files changed, 20 insertions(+) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix oversight in FindTriggerIncompatibleWithInheritance. @ 2025-08-08 08:39 Etsuro Fujita <efujita@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Etsuro Fujita @ 2025-08-08 08:39 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix oversight in FindTriggerIncompatibleWithInheritance. This function is called from ATExecAttachPartition/ATExecAddInherit, which prevent tables with row-level triggers with transition tables from becoming partitions or inheritance children, to check if there is such a trigger on the given table, but failed to check if a found trigger is row-level, causing the caller functions to needlessly prevent a table with only a statement-level trigger with transition tables from becoming a partition or inheritance child. Repair. Oversight in commit 501ed02cf. Author: Etsuro Fujita <etsuro.fujita@gmail.com> Discussion: https://postgr.es/m/CAPmGK167mXzwzzmJ_0YZ3EZrbwiCxtM1vogH_8drqsE6PtxRYw%40mail.gmail.com Backpatch-through: 13 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/9e63f83a7e7f8211581bfe9e9d05b72695261f4f Modified Files -------------- src/backend/commands/trigger.c | 2 ++ src/test/regress/expected/triggers.out | 8 ++++++++ src/test/regress/sql/triggers.sql | 10 ++++++++++ 3 files changed, 20 insertions(+) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix oversight in FindTriggerIncompatibleWithInheritance. @ 2025-08-08 08:39 Etsuro Fujita <efujita@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Etsuro Fujita @ 2025-08-08 08:39 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix oversight in FindTriggerIncompatibleWithInheritance. This function is called from ATExecAttachPartition/ATExecAddInherit, which prevent tables with row-level triggers with transition tables from becoming partitions or inheritance children, to check if there is such a trigger on the given table, but failed to check if a found trigger is row-level, causing the caller functions to needlessly prevent a table with only a statement-level trigger with transition tables from becoming a partition or inheritance child. Repair. Oversight in commit 501ed02cf. Author: Etsuro Fujita <etsuro.fujita@gmail.com> Discussion: https://postgr.es/m/CAPmGK167mXzwzzmJ_0YZ3EZrbwiCxtM1vogH_8drqsE6PtxRYw%40mail.gmail.com Backpatch-through: 13 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/e028ce911ad21e23ca39555e01a2d6c41c76aa79 Modified Files -------------- src/backend/commands/trigger.c | 2 ++ src/test/regress/expected/triggers.out | 8 ++++++++ src/test/regress/sql/triggers.sql | 10 ++++++++++ 3 files changed, 20 insertions(+) ^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2025-08-08 08:39 UTC | newest] Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-08-08 08:39 pgsql: Fix oversight in FindTriggerIncompatibleWithInheritance. Etsuro Fujita <efujita@postgresql.org> 2025-08-08 08:39 pgsql: Fix oversight in FindTriggerIncompatibleWithInheritance. Etsuro Fujita <efujita@postgresql.org> 2025-08-08 08:39 pgsql: Fix oversight in FindTriggerIncompatibleWithInheritance. Etsuro Fujita <efujita@postgresql.org> 2025-08-08 08:39 pgsql: Fix oversight in FindTriggerIncompatibleWithInheritance. Etsuro Fujita <efujita@postgresql.org> 2025-08-08 08:39 pgsql: Fix oversight in FindTriggerIncompatibleWithInheritance. Etsuro Fujita <efujita@postgresql.org> 2025-08-08 08:39 pgsql: Fix oversight in FindTriggerIncompatibleWithInheritance. Etsuro Fujita <efujita@postgresql.org> 2025-08-08 08:39 pgsql: Fix oversight in FindTriggerIncompatibleWithInheritance. Etsuro Fujita <efujita@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox