pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Etsuro Fujita <efujita@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix oversight in FindTriggerIncompatibleWithInheritance.
Date: Fri, 08 Aug 2025 08:39:10 +0000
Message-ID: <E1ukId3-001MR1-34@gemulon.postgresql.org> (raw)

Fix oversight in FindTriggerIncompatibleWithInheritance.

This function is called from ATExecAttachPartition/ATExecAddInherit,
which prevent tables with row-level triggers with transition tables from
becoming partitions or inheritance children, to check if there is such a
trigger on the given table, but failed to check if a found trigger is
row-level, causing the caller functions to needlessly prevent a table
with only a statement-level trigger with transition tables from becoming
a partition or inheritance child.  Repair.

Oversight in commit 501ed02cf.

Author: Etsuro Fujita <etsuro.fujita@gmail.com>
Discussion: https://postgr.es/m/CAPmGK167mXzwzzmJ_0YZ3EZrbwiCxtM1vogH_8drqsE6PtxRYw%40mail.gmail.com
Backpatch-through: 13

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/73eb6afa13605d9bb619752180b739fd3c4ba168

Modified Files
--------------
src/backend/commands/trigger.c         |  2 ++
src/test/regress/expected/triggers.out |  8 ++++++++
src/test/regress/sql/triggers.sql      | 10 ++++++++++
3 files changed, 20 insertions(+)



view thread (7+ messages)  latest in thread

Message-ID: <E1ukId3-001MR1-34@gemulon.postgresql.org>
Permalink:  ../E1ukId3-001MR1-34@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1ukId3-001MR1-34@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: efujita@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix oversight in FindTriggerIncompatibleWithInheritance.
  In-Reply-To: <E1ukId3-001MR1-34@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox