From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove useless/superfluous Datum conversions
Date: Fri, 08 Aug 2025 20:11:47 +0000
Message-ID: <E1ukTRK-001R4d-37@gemulon.postgresql.org> (raw)
Remove useless/superfluous Datum conversions
Remove useless DatumGetFoo() and FooGetDatum() calls. These are
places where no conversion from or to Datum was actually happening.
We think these extra calls covered here were harmless. Some actual
bugs that were discovered during this process have been committed
separately (80c758a2e1d, 2242b26ce47).
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://www.postgresql.org/message-id/flat/8246d7ff-f4b7-4363-913e-827dadfeb145%40eisentraut.org
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/dcfc0f891273eeeb85ce6e723decf5cc37f9b1c3
Modified Files
--------------
src/backend/commands/alter.c | 2 +-
src/backend/executor/execExprInterp.c | 6 +++---
src/backend/rewrite/rewriteDefine.c | 5 ++---
src/backend/statistics/extended_stats.c | 2 +-
src/backend/tsearch/ts_parse.c | 4 ++--
src/backend/utils/activity/pgstat.c | 2 +-
src/backend/utils/adt/json.c | 2 +-
src/backend/utils/adt/multirangetypes.c | 7 +++----
src/backend/utils/adt/rangetypes.c | 4 ++--
src/backend/utils/adt/varlena.c | 5 ++---
src/backend/utils/cache/relcache.c | 2 +-
11 files changed, 19 insertions(+), 22 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Remove useless/superfluous Datum conversions
In-Reply-To: <E1ukTRK-001R4d-37@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox