agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Add missing Datum conversions
Date: Fri, 08 Aug 2025 20:11:47 +0000
Message-ID: <E1ukTRK-001R4f-3A@gemulon.postgresql.org> (raw)
Add missing Datum conversions
Add various missing conversions from and to Datum. The previous code
mostly relied on implicit conversions or its own explicit casts
instead of using the correct DatumGet*() or *GetDatum() functions.
We think these omissions are harmless. Some actual bugs that were
discovered during this process have been committed
separately (80c758a2e1d, fd2ab03fea2).
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://www.postgresql.org/message-id/flat/8246d7ff-f4b7-4363-913e-827dadfeb145%40eisentraut.org
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/ff89e182d42048380dba32fee1b491893c7b4bec
Modified Files
--------------
contrib/btree_gist/btree_enum.c | 4 ++--
contrib/btree_gist/btree_numeric.c | 2 +-
contrib/btree_gist/btree_utils_num.c | 22 +++++++++++-----------
contrib/intarray/_int_op.c | 2 +-
contrib/pageinspect/heapfuncs.c | 2 +-
contrib/pgrowlocks/pgrowlocks.c | 4 ++--
contrib/seg/seg.c | 4 ++--
src/backend/access/brin/brin.c | 4 ++--
src/backend/access/brin/brin_bloom.c | 2 +-
src/backend/access/brin/brin_minmax.c | 10 +++++-----
src/backend/access/brin/brin_minmax_multi.c | 6 +++---
src/backend/access/common/heaptuple.c | 2 +-
src/backend/access/common/toast_internals.c | 4 ++--
src/backend/catalog/objectaddress.c | 4 ++--
src/backend/catalog/pg_proc.c | 2 +-
src/backend/catalog/pg_publication.c | 2 +-
src/backend/catalog/pg_shdepend.c | 12 ++++++------
src/backend/commands/event_trigger.c | 4 ++--
src/backend/commands/subscriptioncmds.c | 8 ++++----
src/backend/commands/tablecmds.c | 2 +-
src/backend/commands/trigger.c | 2 +-
src/backend/commands/tsearchcmds.c | 8 ++++----
src/backend/commands/user.c | 6 +++---
src/backend/executor/execExprInterp.c | 2 +-
src/backend/statistics/attribute_stats.c | 6 +++---
src/backend/storage/aio/aio_funcs.c | 2 +-
src/backend/storage/buffer/bufmgr.c | 4 ++--
src/backend/storage/ipc/shmem.c | 2 +-
src/backend/storage/lmgr/lock.c | 4 ++--
src/backend/utils/adt/datum.c | 6 +++---
src/backend/utils/adt/jsonpath_exec.c | 2 +-
src/backend/utils/adt/lockfuncs.c | 8 ++++----
src/backend/utils/adt/multirangetypes.c | 12 ++++++------
src/backend/utils/adt/rangetypes.c | 8 ++++----
src/backend/utils/adt/rangetypes_spgist.c | 2 +-
src/backend/utils/adt/rowtypes.c | 4 ++--
src/backend/utils/adt/waitfuncs.c | 2 +-
src/backend/utils/cache/attoptcache.c | 2 +-
src/backend/utils/cache/lsyscache.c | 2 +-
src/backend/utils/cache/relcache.c | 2 +-
src/backend/utils/cache/syscache.c | 6 +++---
src/backend/utils/sort/sortsupport.c | 2 +-
src/backend/utils/sort/tuplesortvariants.c | 6 +++---
src/pl/plperl/plperl.c | 10 +++++-----
src/test/regress/regress.c | 2 +-
45 files changed, 107 insertions(+), 107 deletions(-)
view thread (2+ messages) latest in thread
Message-ID: <E1ukTRK-001R4f-3A@gemulon.postgresql.org>
Permalink: ../E1ukTRK-001R4f-3A@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1ukTRK-001R4f-3A@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add missing Datum conversions
In-Reply-To: <E1ukTRK-001R4f-3A@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox