pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove useless pointer update in StatsShmemInit()
Date: Tue, 19 Aug 2025 00:54:57 +0000
Message-ID: <E1uoAcq-000YwD-2q@gemulon.postgresql.org> (raw)

Remove useless pointer update in StatsShmemInit()

This pointer was not used after its last update.  This variable
assignment was most likely a vestige artifact of the earlier versions of
the patch set that have led to 5891c7a8ed8f.

This pointer update is useless, so let's remove it.  It removes one call
to pgstat_dsa_init_size(), making the code slightly easier to grasp.

Author: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Discussion: https://postgr.es/m/aKLsu2sdpnyeuSSc@ip-10-97-1-34.eu-west-3.compute.internal

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/9b7eb6f02e8d4affb225dd0aa239c8e7e0ff2cba

Modified Files
--------------
src/backend/utils/activity/pgstat_shmem.c | 1 -
1 file changed, 1 deletion(-)



Message-ID: <E1uoAcq-000YwD-2q@gemulon.postgresql.org>
Permalink:  ../E1uoAcq-000YwD-2q@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1uoAcq-000YwD-2q@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Remove useless pointer update in StatsShmemInit()
  In-Reply-To: <E1uoAcq-000YwD-2q@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox