pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Use consistent type for pgaio_io_get_id() result 2+ messages / 1 participants [nested] [flat]
* pgsql: Use consistent type for pgaio_io_get_id() result @ 2025-08-21 17:55 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 2+ messages in thread From: Peter Eisentraut @ 2025-08-21 17:55 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Use consistent type for pgaio_io_get_id() result The result of pgaio_io_get_id() was being assigned to a mix of int and uint32 variables. This fixes it to use int consistently, which seems the most correct. Also change the queue empty special value in method_worker.c to -1 from UINT32_MAX. Reviewed-by: Andres Freund <andres@anarazel.de> Discussion: https://www.postgresql.org/message-id/70c784b3-f60b-4652-b8a6-75e5f051243e%40eisentraut.org Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/47932f3cdc4c221dbd9207cb21e63c862fedd189 Modified Files -------------- src/backend/storage/aio/aio_funcs.c | 4 ++-- src/backend/storage/aio/method_worker.c | 14 +++++++------- 2 files changed, 9 insertions(+), 9 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Use consistent type for pgaio_io_get_id() result @ 2025-08-21 17:55 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 2+ messages in thread From: Peter Eisentraut @ 2025-08-21 17:55 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Use consistent type for pgaio_io_get_id() result The result of pgaio_io_get_id() was being assigned to a mix of int and uint32 variables. This fixes it to use int consistently, which seems the most correct. Also change the queue empty special value in method_worker.c to -1 from UINT32_MAX. Reviewed-by: Andres Freund <andres@anarazel.de> Discussion: https://www.postgresql.org/message-id/70c784b3-f60b-4652-b8a6-75e5f051243e%40eisentraut.org Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/b942360f82a0fe0c450ba54f01cac0c594cf08a4 Modified Files -------------- src/backend/storage/aio/aio_funcs.c | 4 ++-- src/backend/storage/aio/method_worker.c | 14 +++++++------- 2 files changed, 9 insertions(+), 9 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2025-08-21 17:55 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-08-21 17:55 pgsql: Use consistent type for pgaio_io_get_id() result Peter Eisentraut <peter@eisentraut.org> 2025-08-21 17:55 pgsql: Use consistent type for pgaio_io_get_id() result Peter Eisentraut <peter@eisentraut.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox