From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Use consistent type for pgaio_io_get_id() result
Date: Thu, 21 Aug 2025 17:55:29 +0000
Message-ID: <E1up9VY-0010Se-1M@gemulon.postgresql.org> (raw)
Use consistent type for pgaio_io_get_id() result
The result of pgaio_io_get_id() was being assigned to a mix of int and
uint32 variables. This fixes it to use int consistently, which seems
the most correct. Also change the queue empty special value in
method_worker.c to -1 from UINT32_MAX.
Reviewed-by: Andres Freund <andres@anarazel.de>
Discussion: https://www.postgresql.org/message-id/70c784b3-f60b-4652-b8a6-75e5f051243e%40eisentraut.org
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/47932f3cdc4c221dbd9207cb21e63c862fedd189
Modified Files
--------------
src/backend/storage/aio/aio_funcs.c | 4 ++--
src/backend/storage/aio/method_worker.c | 14 +++++++-------
2 files changed, 9 insertions(+), 9 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Use consistent type for pgaio_io_get_id() result
In-Reply-To: <E1up9VY-0010Se-1M@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox