pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Noah Misch <noah@leadboat.com>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Sort DO_DEFAULT_ACL dump objects independent of OIDs.
Date: Sat, 23 Aug 2025 03:53:46 +0000
Message-ID: <E1upfK6-001EX9-0D@gemulon.postgresql.org> (raw)

Sort DO_DEFAULT_ACL dump objects independent of OIDs.

Commit 0decd5e89db9f5edb9b27351082f0d74aae7a9b6 missed DO_DEFAULT_ACL,
leading to assertion failures, potential dump order instability, and
spurious schema diffs.  Back-patch to v13, like that commit.

Reported-by: Alexander Lakhin <exclusion@gmail.com>
Author: Kirill Reshke <reshkekirill@gmail.com>
Discussion: https://postgr.es/m/d32aaa8d-df7c-4f94-bcb3-4c85f02bea21@gmail.com
Backpatch-through: 13

Branch
------
REL_17_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/e8d22095e5df4d22513ce553998eef899f5f0692

Modified Files
--------------
src/bin/pg_dump/pg_dump_sort.c           | 13 +++++++++++++
src/test/regress/expected/privileges.out |  5 +++++
src/test/regress/sql/privileges.sql      |  7 +++++++
3 files changed, 25 insertions(+)



view thread (7+ messages)  latest in thread

Message-ID: <E1upfK6-001EX9-0D@gemulon.postgresql.org>
Permalink:  ../E1upfK6-001EX9-0D@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1upfK6-001EX9-0D@gemulon.postgresql.org

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: noah@leadboat.com, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Sort DO_DEFAULT_ACL dump objects independent of OIDs.
  In-Reply-To: <E1upfK6-001EX9-0D@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox