pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Improve objectNamesToOids() comment
Date: Wed, 27 Aug 2025 15:54:37 +0000
Message-ID: <E1urITt-001wB5-0d@gemulon.postgresql.org> (raw)

Improve objectNamesToOids() comment

Commit d31bbfb6590 removed the comment at objectNamesToOids() that
there is no locking, because that commit added locking.  But to fix
all the problems, we'd still need a stronger lock.  So put the comment
back with more a detailed explanation.

Co-authored-by: Noah Misch <noah@leadboat.com>
Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi>
Discussion: https://www.postgresql.org/message-id/flat/bf72b82c-124d-4efa-a484-bb928e9494e4@eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e36fa9319b1366ee0194e130a9a77c4af7ee1853

Modified Files
--------------
src/backend/catalog/aclchk.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)



view thread (2+ messages)

Message-ID: <E1urITt-001wB5-0d@gemulon.postgresql.org>
Permalink:  ../E1urITt-001wB5-0d@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1urITt-001wB5-0d@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Improve objectNamesToOids() comment
  In-Reply-To: <E1urITt-001wB5-0d@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox