pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Improve objectNamesToOids() comment
2+ messages / 1 participants
[nested] [flat]

* pgsql: Improve objectNamesToOids() comment
@ 2025-08-27 15:54 Peter Eisentraut <peter@eisentraut.org>
  0 siblings, 0 replies; 2+ messages in thread

From: Peter Eisentraut @ 2025-08-27 15:54 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Improve objectNamesToOids() comment

Commit d31bbfb6590 removed the comment at objectNamesToOids() that
there is no locking, because that commit added locking.  But to fix
all the problems, we'd still need a stronger lock.  So put the comment
back with more a detailed explanation.

Co-authored-by: Noah Misch <noah@leadboat.com>
Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi>
Discussion: https://www.postgresql.org/message-id/flat/bf72b82c-124d-4efa-a484-bb928e9494e4@eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e36fa9319b1366ee0194e130a9a77c4af7ee1853

Modified Files
--------------
src/backend/catalog/aclchk.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* pgsql: Improve objectNamesToOids() comment
@ 2025-08-27 15:54 Peter Eisentraut <peter@eisentraut.org>
  0 siblings, 0 replies; 2+ messages in thread

From: Peter Eisentraut @ 2025-08-27 15:54 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Improve objectNamesToOids() comment

Commit d31bbfb6590 removed the comment at objectNamesToOids() that
there is no locking, because that commit added locking.  But to fix
all the problems, we'd still need a stronger lock.  So put the comment
back with more a detailed explanation.

Co-authored-by: Noah Misch <noah@leadboat.com>
Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi>
Discussion: https://www.postgresql.org/message-id/flat/bf72b82c-124d-4efa-a484-bb928e9494e4@eisentraut.org

Branch
------
REL_18_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/118601a7e8c088306fe952ff298afd687483b35e

Modified Files
--------------
src/backend/catalog/aclchk.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2025-08-27 15:54 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-08-27 15:54 pgsql: Improve objectNamesToOids() comment Peter Eisentraut <peter@eisentraut.org>
2025-08-27 15:54 pgsql: Improve objectNamesToOids() comment Peter Eisentraut <peter@eisentraut.org>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox