pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Richard Guo <rguo@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix semijoin unique-ification for child relations
Date: Fri, 29 Aug 2025 04:17:17 +0000
Message-ID: <E1urqY9-002Alu-1B@gemulon.postgresql.org> (raw)

Fix semijoin unique-ification for child relations

For a child relation, we should not assume that its parent's
unique-ified relation (or unique-ified path in v18) always exists.  In
cases where all RHS columns that need to be unique-ified are equated
to constants, the unique-ified relation/path for the parent table is
not built, as there are no columns left to unique-ify.  Failing to
account for this can result in a SIGSEGV crash during planning.

This patch checks whether the parent's unique-ified relation or path
exists and skips unique-ification of the child relation if it does
not.

Author: Richard Guo <guofenglinux@gmail.com>
Discussion: https://postgr.es/m/CAMbWs49MOdLW2c+qbLHHBt8VBu=4ONpM91D19=AWeW93eFUF6A@mail.gmail.com
Backpatch-through: 18

Branch
------
REL_18_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/58ea074f1433abdd5de792e47ae84c1e56c263f9

Modified Files
--------------
src/backend/optimizer/util/pathnode.c |  9 ++++++
src/test/regress/expected/join.out    | 60 +++++++++++++++++++++++++++++++++++
src/test/regress/sql/join.sql         | 37 +++++++++++++++++++++
3 files changed, 106 insertions(+)



view thread (2+ messages)

Message-ID: <E1urqY9-002Alu-1B@gemulon.postgresql.org>
Permalink:  ../E1urqY9-002Alu-1B@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1urqY9-002Alu-1B@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: rguo@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix semijoin unique-ification for child relations
  In-Reply-To: <E1urqY9-002Alu-1B@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox