pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Richard Guo <rguo@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix misuse of Relids for storing attribute numbers
Date: Fri, 12 Sep 2025 02:13:09 +0000
Message-ID: <E1uwtHh-000Gvz-0x@gemulon.postgresql.org> (raw)

Fix misuse of Relids for storing attribute numbers

The typedef Relids (Bitmapset *) is intended to represent set of
relation identifiers, but was incorrectly used in several places to
store sets of attribute numbers.  This is my oversight in e2debb643.

Fix that by replacing such usages with Bitmapset * to reflect the
correct semantics.

Author: Junwang Zhao <zhjwpku@gmail.com>
Reviewed-by: Tender Wang <tndrwang@gmail.com>
Reviewed-by: Richard Guo <guofenglinux@gmail.com>
Discussion: https://postgr.es/m/CAEG8a3LJhp_xriXf39iCz0TsK+M-2biuhDhpLC6Baxw8+ZYT3A@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2d756ebbe857e3d395d18350bf232300ebd23981

Modified Files
--------------
src/backend/optimizer/util/clauses.c | 2 +-
src/backend/optimizer/util/plancat.c | 6 +++---
src/include/optimizer/plancat.h      | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)



Message-ID: <E1uwtHh-000Gvz-0x@gemulon.postgresql.org>
Permalink:  ../E1uwtHh-000Gvz-0x@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1uwtHh-000Gvz-0x@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: rguo@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix misuse of Relids for storing attribute numbers
  In-Reply-To: <E1uwtHh-000Gvz-0x@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox