pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Fujii Masao <fujii@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pg_restore: Fix security label handling with --no-publications/s
Date: Thu, 18 Sep 2025 02:12:51 +0000
Message-ID: <E1uz48g-001G61-2F@gemulon.postgresql.org> (raw)

pg_restore: Fix security label handling with --no-publications/subscriptions.

Previously, pg_restore did not skip security labels on publications or
subscriptions even when --no-publications or --no-subscriptions was specified.
As a result, it could issue SECURITY LABEL commands for objects that were
never created, causing those commands to fail.

This commit fixes the issue by ensuring that security labels on publications
and subscriptions are also skipped when the corresponding options are used.

Backpatch to all supported versions.

Author: Jian He <jian.universality@gmail.com>
Reviewed-by: Fujii Masao <masao.fujii@gmail.com>
Discussion: https://postgr.es/m/CACJufxHCt00pR9h51AVu6+yPD5J7JQn=7dQXxqacj0XyDhc-fA@mail.gmail.com
Backpatch-through: 13

Branch
------
REL_17_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/dc8aa2f586d039d53198c895c3de762a98e59016

Modified Files
--------------
src/bin/pg_dump/pg_backup_archiver.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)



view thread (7+ messages)  latest in thread

Message-ID: <E1uz48g-001G61-2F@gemulon.postgresql.org>
Permalink:  ../E1uz48g-001G61-2F@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1uz48g-001G61-2F@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: fujii@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: pg_restore: Fix security label handling with --no-publications/s
  In-Reply-To: <E1uz48g-001G61-2F@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox