pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Add a test module for Bitmapset
Date: Mon, 22 Sep 2025 07:55:24 +0000
Message-ID: <E1v0bON-001uYi-27@gemulon.postgresql.org> (raw)

Add a test module for Bitmapset

Bitmapset has a complex set of APIs, defined in bitmapset.h, and it can
be hard to test edge cases with the backend core code only.

This test module is aimed at closing the gap, and implements a set of
SQL functions that act as wrappers of the low-level C functions of the
same names.  These functions rely on text as data type for the input and
the output as Bitmapset as a node has support for these.  An extra
function, named test_random_operations(), can be used to stress bitmaps
with random member values and a defined number of operations potentially
useful for other purposes than only tests.

The coverage increases from 85.2% to 93.4%.  It should be possible to
cover more code paths, but at least it's a beginning.

Author: Greg Burd <greg@burd.me>
Reviewed-by: Nathan Bossart <nathandbossart@gmail.com>
Reviewed-by: Michael Paquier <michael@paquier.xyz>
Discussion: https://postgr.es/m/7BD1ABDB-B03A-464A-9BA9-A73B55AD8A1F@getmailspring.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/00c3d87a5cab6e1b816658f15573ea4730c2f17b

Modified Files
--------------
src/test/modules/Makefile                          |    1 +
src/test/modules/meson.build                       |    1 +
src/test/modules/test_bitmapset/.gitignore         |    4 +
src/test/modules/test_bitmapset/Makefile           |   23 +
.../test_bitmapset/expected/test_bitmapset.out     |  907 +++++++++++++++++
src/test/modules/test_bitmapset/meson.build        |   33 +
.../modules/test_bitmapset/sql/test_bitmapset.sql  |  257 +++++
.../modules/test_bitmapset/test_bitmapset--1.0.sql |  136 +++
src/test/modules/test_bitmapset/test_bitmapset.c   | 1021 ++++++++++++++++++++
.../modules/test_bitmapset/test_bitmapset.control  |    4 +
10 files changed, 2387 insertions(+)



Message-ID: <E1v0bON-001uYi-27@gemulon.postgresql.org>
Permalink:  ../E1v0bON-001uYi-27@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1v0bON-001uYi-27@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Add a test module for Bitmapset
  In-Reply-To: <E1v0bON-001uYi-27@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox