pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Masahiko Sawada <msawada@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: psql: Add COMPLETE_WITH_FILES and COMPLETE_WITH_GENERATOR macros
Date: Thu, 25 Sep 2025 21:28:40 +0000
Message-ID: <E1v1tW4-0004iq-1L@gemulon.postgresql.org> (raw)

psql: Add COMPLETE_WITH_FILES and COMPLETE_WITH_GENERATOR macros.

While most tab completions in match_previous_words() use
COMPLETE_WITH* macros to wrap rl_completion_matches(), some direct
calls to rl_completion_matches() still remained.

This commit introduces COMPLETE_WITH_FILES and COMPLETE_WITH_GENERATOR
macros to replace these direct calls, enhancing both code consistency
and readability.

Author: Yugo Nagata <nagata@sraoss.co.jp>
Reviewed-by: Masahiko Sawada <sawada.mshk@gmail.com>
Discussion: https://postgr.es/m/20250605100835.b396f9d656df1018f65a4556@sraoss.co.jp

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/76418a0b676234d2b570a1138c1a43a2018c416f

Modified Files
--------------
src/bin/psql/tab-complete.in.c | 38 ++++++++++++++++++--------------------
1 file changed, 18 insertions(+), 20 deletions(-)



Message-ID: <E1v1tW4-0004iq-1L@gemulon.postgresql.org>
Permalink:  ../E1v1tW4-0004iq-1L@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1v1tW4-0004iq-1L@gemulon.postgresql.org

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: msawada@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: psql: Add COMPLETE_WITH_FILES and COMPLETE_WITH_GENERATOR macros
  In-Reply-To: <E1v1tW4-0004iq-1L@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox