pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove duplicated log related to slot creation in pg_createsubsc
Date: Thu, 09 Oct 2025 05:02:40 +0000
Message-ID: <E1v6inY-000n2N-1Z@gemulon.postgresql.org> (raw)

Remove duplicated log related to slot creation in pg_createsubscriber

The creation of a replication slot done in a specific database on a
publisher was logged twice, with the second log not mentioning the
database where the slot creation happened.  This commit removes the
information logged after a slot has been successfully created, moving
the information about the publisher from the second to the first log.
Note that failing a slot creation is also logged, so there is no loss of
information.

Author: Peter Smith <smithpb2250@gmail.com>
Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Discussion: https://postgr.es/m/CAHut+Pv7qDvLbDgc9PQGhULT3rPXTxdu_=w+iW-kMs+zPADR+w@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/8d02f49696d81b1641412c2f4545403de37faadc

Modified Files
--------------
src/bin/pg_basebackup/pg_createsubscriber.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)



Message-ID: <E1v6inY-000n2N-1Z@gemulon.postgresql.org>
Permalink:  ../E1v6inY-000n2N-1Z@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1v6inY-000n2N-1Z@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Remove duplicated log related to slot creation in pg_createsubsc
  In-Reply-To: <E1v6inY-000n2N-1Z@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox