pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Geoghegan <pg@bowt.ie>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove overzealous _bt_killitems assertion.
Date: Fri, 10 Oct 2025 18:52:38 +0000
Message-ID: <E1v7IEI-0012us-0O@gemulon.postgresql.org> (raw)

Remove overzealous _bt_killitems assertion.

An assertion in _bt_killitems expected the scan's currPos state to
contain a valid LSN, saved from when currPos's page was initially read.
The assertion failed to account for the fact that even logged relations
can have leaf pages with an invalid LSN when built with wal_level set to
"minimal".  Remove the faulty assertion.

Oversight in commit e6eed40e (though note that the assertion was
backpatched to stable branches before 18 by commit 7c319f54).

Author: Peter Geoghegan <pg@bowt.ie>
Reported-By: Matthijs van der Vleuten <postgresql@zr40.nl>
Bug: #19082
Discussion: https://postgr.es/m/19082-628e62160dbbc1c1@postgresql.org
Backpatch-through: 13

Branch
------
REL_17_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/ae15cebc2035b77626e7d55757324b429c5e1f38

Modified Files
--------------
src/backend/access/nbtree/nbtutils.c | 1 -
1 file changed, 1 deletion(-)



view thread (7+ messages)  latest in thread

Message-ID: <E1v7IEI-0012us-0O@gemulon.postgresql.org>
Permalink:  ../E1v7IEI-0012us-0O@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1v7IEI-0012us-0O@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: pg@bowt.ie, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Remove overzealous _bt_killitems assertion.
  In-Reply-To: <E1v7IEI-0012us-0O@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox