pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Remove overzealous _bt_killitems assertion. 7+ messages / 1 participants [nested] [flat]
* pgsql: Remove overzealous _bt_killitems assertion. @ 2025-10-10 18:52 Peter Geoghegan <pg@bowt.ie> 0 siblings, 0 replies; 7+ messages in thread From: Peter Geoghegan @ 2025-10-10 18:52 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove overzealous _bt_killitems assertion. An assertion in _bt_killitems expected the scan's currPos state to contain a valid LSN, saved from when currPos's page was initially read. The assertion failed to account for the fact that even logged relations can have leaf pages with an invalid LSN when built with wal_level set to "minimal". Remove the faulty assertion. Oversight in commit e6eed40e (though note that the assertion was backpatched to stable branches before 18 by commit 7c319f54). Author: Peter Geoghegan <pg@bowt.ie> Reported-By: Matthijs van der Vleuten <postgresql@zr40.nl> Bug: #19082 Discussion: https://postgr.es/m/19082-628e62160dbbc1c1@postgresql.org Backpatch-through: 13 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/843e50208a31b9e17e9ab530c93a158425cfb8ba Modified Files -------------- src/backend/access/nbtree/nbtutils.c | 1 - 1 file changed, 1 deletion(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Remove overzealous _bt_killitems assertion. @ 2025-10-10 18:52 Peter Geoghegan <pg@bowt.ie> 0 siblings, 0 replies; 7+ messages in thread From: Peter Geoghegan @ 2025-10-10 18:52 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove overzealous _bt_killitems assertion. An assertion in _bt_killitems expected the scan's currPos state to contain a valid LSN, saved from when currPos's page was initially read. The assertion failed to account for the fact that even logged relations can have leaf pages with an invalid LSN when built with wal_level set to "minimal". Remove the faulty assertion. Oversight in commit e6eed40e (though note that the assertion was backpatched to stable branches before 18 by commit 7c319f54). Author: Peter Geoghegan <pg@bowt.ie> Reported-By: Matthijs van der Vleuten <postgresql@zr40.nl> Bug: #19082 Discussion: https://postgr.es/m/19082-628e62160dbbc1c1@postgresql.org Backpatch-through: 13 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/61de81a496dcd50187e8de765f4c3ed0267764ef Modified Files -------------- src/backend/access/nbtree/nbtutils.c | 1 - 1 file changed, 1 deletion(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Remove overzealous _bt_killitems assertion. @ 2025-10-10 18:52 Peter Geoghegan <pg@bowt.ie> 0 siblings, 0 replies; 7+ messages in thread From: Peter Geoghegan @ 2025-10-10 18:52 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove overzealous _bt_killitems assertion. An assertion in _bt_killitems expected the scan's currPos state to contain a valid LSN, saved from when currPos's page was initially read. The assertion failed to account for the fact that even logged relations can have leaf pages with an invalid LSN when built with wal_level set to "minimal". Remove the faulty assertion. Oversight in commit e6eed40e (though note that the assertion was backpatched to stable branches before 18 by commit 7c319f54). Author: Peter Geoghegan <pg@bowt.ie> Reported-By: Matthijs van der Vleuten <postgresql@zr40.nl> Bug: #19082 Discussion: https://postgr.es/m/19082-628e62160dbbc1c1@postgresql.org Backpatch-through: 13 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/ae15cebc2035b77626e7d55757324b429c5e1f38 Modified Files -------------- src/backend/access/nbtree/nbtutils.c | 1 - 1 file changed, 1 deletion(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Remove overzealous _bt_killitems assertion. @ 2025-10-10 18:52 Peter Geoghegan <pg@bowt.ie> 0 siblings, 0 replies; 7+ messages in thread From: Peter Geoghegan @ 2025-10-10 18:52 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove overzealous _bt_killitems assertion. An assertion in _bt_killitems expected the scan's currPos state to contain a valid LSN, saved from when currPos's page was initially read. The assertion failed to account for the fact that even logged relations can have leaf pages with an invalid LSN when built with wal_level set to "minimal". Remove the faulty assertion. Oversight in commit e6eed40e (though note that the assertion was backpatched to stable branches before 18 by commit 7c319f54). Author: Peter Geoghegan <pg@bowt.ie> Reported-By: Matthijs van der Vleuten <postgresql@zr40.nl> Bug: #19082 Discussion: https://postgr.es/m/19082-628e62160dbbc1c1@postgresql.org Backpatch-through: 13 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/c160fd46910e7ad9490578b453847f06ffb3f5ee Modified Files -------------- src/backend/access/nbtree/nbtutils.c | 1 - 1 file changed, 1 deletion(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Remove overzealous _bt_killitems assertion. @ 2025-10-10 18:52 Peter Geoghegan <pg@bowt.ie> 0 siblings, 0 replies; 7+ messages in thread From: Peter Geoghegan @ 2025-10-10 18:52 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove overzealous _bt_killitems assertion. An assertion in _bt_killitems expected the scan's currPos state to contain a valid LSN, saved from when currPos's page was initially read. The assertion failed to account for the fact that even logged relations can have leaf pages with an invalid LSN when built with wal_level set to "minimal". Remove the faulty assertion. Oversight in commit e6eed40e (though note that the assertion was backpatched to stable branches before 18 by commit 7c319f54). Author: Peter Geoghegan <pg@bowt.ie> Reported-By: Matthijs van der Vleuten <postgresql@zr40.nl> Bug: #19082 Discussion: https://postgr.es/m/19082-628e62160dbbc1c1@postgresql.org Backpatch-through: 13 Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/ca0c9390865dbd5a7324cf390f696ade33494974 Modified Files -------------- src/backend/access/nbtree/nbtutils.c | 1 - 1 file changed, 1 deletion(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Remove overzealous _bt_killitems assertion. @ 2025-10-10 18:52 Peter Geoghegan <pg@bowt.ie> 0 siblings, 0 replies; 7+ messages in thread From: Peter Geoghegan @ 2025-10-10 18:52 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove overzealous _bt_killitems assertion. An assertion in _bt_killitems expected the scan's currPos state to contain a valid LSN, saved from when currPos's page was initially read. The assertion failed to account for the fact that even logged relations can have leaf pages with an invalid LSN when built with wal_level set to "minimal". Remove the faulty assertion. Oversight in commit e6eed40e (though note that the assertion was backpatched to stable branches before 18 by commit 7c319f54). Author: Peter Geoghegan <pg@bowt.ie> Reported-By: Matthijs van der Vleuten <postgresql@zr40.nl> Bug: #19082 Discussion: https://postgr.es/m/19082-628e62160dbbc1c1@postgresql.org Backpatch-through: 13 Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/314004021e549770d3d57fd0cf286050b948472d Modified Files -------------- src/backend/access/nbtree/nbtutils.c | 1 - 1 file changed, 1 deletion(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Remove overzealous _bt_killitems assertion. @ 2025-10-10 18:52 Peter Geoghegan <pg@bowt.ie> 0 siblings, 0 replies; 7+ messages in thread From: Peter Geoghegan @ 2025-10-10 18:52 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove overzealous _bt_killitems assertion. An assertion in _bt_killitems expected the scan's currPos state to contain a valid LSN, saved from when currPos's page was initially read. The assertion failed to account for the fact that even logged relations can have leaf pages with an invalid LSN when built with wal_level set to "minimal". Remove the faulty assertion. Oversight in commit e6eed40e (though note that the assertion was backpatched to stable branches before 18 by commit 7c319f54). Author: Peter Geoghegan <pg@bowt.ie> Reported-By: Matthijs van der Vleuten <postgresql@zr40.nl> Bug: #19082 Discussion: https://postgr.es/m/19082-628e62160dbbc1c1@postgresql.org Backpatch-through: 13 Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/af302ff6b84ab136533e98b69f645fc271338915 Modified Files -------------- src/backend/access/nbtree/nbtutils.c | 1 - 1 file changed, 1 deletion(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2025-10-10 18:52 UTC | newest] Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-10-10 18:52 pgsql: Remove overzealous _bt_killitems assertion. Peter Geoghegan <pg@bowt.ie> 2025-10-10 18:52 pgsql: Remove overzealous _bt_killitems assertion. Peter Geoghegan <pg@bowt.ie> 2025-10-10 18:52 pgsql: Remove overzealous _bt_killitems assertion. Peter Geoghegan <pg@bowt.ie> 2025-10-10 18:52 pgsql: Remove overzealous _bt_killitems assertion. Peter Geoghegan <pg@bowt.ie> 2025-10-10 18:52 pgsql: Remove overzealous _bt_killitems assertion. Peter Geoghegan <pg@bowt.ie> 2025-10-10 18:52 pgsql: Remove overzealous _bt_killitems assertion. Peter Geoghegan <pg@bowt.ie> 2025-10-10 18:52 pgsql: Remove overzealous _bt_killitems assertion. Peter Geoghegan <pg@bowt.ie>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox