pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Masahiko Sawada <msawada@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Revert "pg_createsubscriber: Add log message when no publication
Date: Wed, 15 Oct 2025 00:36:31 +0000
Message-ID: <E1v8pVH-001jdF-1l@gemulon.postgresql.org> (raw)

Revert "pg_createsubscriber: Add log message when no publications exist to drop."

This reverts commit 74ac377d75135e02064fc4427bec401277b4f60c.

The previous change contained a misconception about how publications
are cleaned up on the subscriber. The newly added log message could
confuse users, particularly when running pg_createsubscriber with
--dry-run - users would see a "dropping publication" message
immediately followed by a "no publications found" message.

Discussion: https://postgr.es/m/CAHut+Pu7xz1LqNvyQyvSHrV0Sw6D=e6T-Jm=gh1MRJrkuWGyBQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/45a7faf130176ae7c152413967c7c90068476a94

Modified Files
--------------
src/bin/pg_basebackup/pg_createsubscriber.c | 13 ++++---------
1 file changed, 4 insertions(+), 9 deletions(-)



Message-ID: <E1v8pVH-001jdF-1l@gemulon.postgresql.org>
Permalink:  ../E1v8pVH-001jdF-1l@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1v8pVH-001jdF-1l@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: msawada@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Revert "pg_createsubscriber: Add log message when no publication
  In-Reply-To: <E1v8pVH-001jdF-1l@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox