pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Álvaro Herrera <alvherre@kurilemu.de>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix pg_dump sorting of foreign key constraints
Date: Sat, 18 Oct 2025 15:54:17 +0000
Message-ID: <E1vA9G5-002K1Q-13@gemulon.postgresql.org> (raw)

Fix pg_dump sorting of foreign key constraints

Apparently, commit 04bc2c42f765 failed to notice that DO_FK_CONSTRAINT
objects require identical handling as DO_CONSTRAINT ones, which causes
some pg_upgrade tests in debug builds to fail spuriously.  Add that.

Author: Álvaro Herrera <alvherre@kurilemu.de>
Backpatch-through: 13
Discussion: https://postgr.es/m/202510181201.k6y75v2tpf5r@alvherre.pgsql

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4921a5972a345fd3118f47a9e425ec862d8a8333

Modified Files
--------------
src/bin/pg_dump/pg_dump_sort.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

view thread (7+ messages)  latest in thread

Message-ID: <E1vA9G5-002K1Q-13@gemulon.postgresql.org>
Permalink:  ../E1vA9G5-002K1Q-13@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1vA9G5-002K1Q-13@gemulon.postgresql.org

copy link · copy postgr.es

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: alvherre@kurilemu.de, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix pg_dump sorting of foreign key constraints
  In-Reply-To: <E1vA9G5-002K1Q-13@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox