pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix thinko in commit 7d129ba54.
Date: Mon, 20 Oct 2025 12:46:07 +0000
Message-ID: <E1vApH5-002bwe-1x@gemulon.postgresql.org> (raw)

Fix thinko in commit 7d129ba54.

The revised logic in 001_ssltests.pl would fail if openssl
doesn't work or if Perl is a 32-bit build, because it had
already overwritten $serialno with something inappropriate
to use in the eventual match.  We could go back to the
previous code layout, but it seems best to introduce a
separate variable for the output of openssl.

Per failure on buildfarm member mamba, which has a 32-bit Perl.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d74cfe3263fa0a35cb962570697f422775cd12d6

Modified Files
--------------
src/test/ssl/t/001_ssltests.pl | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)



view thread (5+ messages)  latest in thread

Message-ID: <E1vApH5-002bwe-1x@gemulon.postgresql.org>
Permalink:  ../E1vApH5-002bwe-1x@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1vApH5-002bwe-1x@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix thinko in commit 7d129ba54.
  In-Reply-To: <E1vApH5-002bwe-1x@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox