pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Fix thinko in commit 7d129ba54.
5+ messages / 2 participants
[nested] [flat]
* pgsql: Fix thinko in commit 7d129ba54.
@ 2025-10-20 12:46 Tom Lane <tgl@sss.pgh.pa.us>
2025-10-21 13:19 ` Re: pgsql: Fix thinko in commit 7d129ba54. Daniel Gustafsson <daniel@yesql.se>
0 siblings, 1 reply; 5+ messages in thread
From: Tom Lane @ 2025-10-20 12:46 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix thinko in commit 7d129ba54.
The revised logic in 001_ssltests.pl would fail if openssl
doesn't work or if Perl is a 32-bit build, because it had
already overwritten $serialno with something inappropriate
to use in the eventual match. We could go back to the
previous code layout, but it seems best to introduce a
separate variable for the output of openssl.
Per failure on buildfarm member mamba, which has a 32-bit Perl.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/d74cfe3263fa0a35cb962570697f422775cd12d6
Modified Files
--------------
src/test/ssl/t/001_ssltests.pl | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: pgsql: Fix thinko in commit 7d129ba54.
2025-10-20 12:46 pgsql: Fix thinko in commit 7d129ba54. Tom Lane <tgl@sss.pgh.pa.us>
@ 2025-10-21 13:19 ` Daniel Gustafsson <daniel@yesql.se>
0 siblings, 0 replies; 5+ messages in thread
From: Daniel Gustafsson @ 2025-10-21 13:19 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: pgsql-committers@lists.postgresql.org
> On 20 Oct 2025, at 14:46, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Fix thinko in commit 7d129ba54.
Ugh, I missed this buildfarm breakage =( I apologise for the oversight and
thanks for fixing!
--
Daniel Gustafsson
^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Fix thinko in commit 7d129ba54.
@ 2025-10-20 12:46 Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 5+ messages in thread
From: Tom Lane @ 2025-10-20 12:46 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix thinko in commit 7d129ba54.
The revised logic in 001_ssltests.pl would fail if openssl
doesn't work or if Perl is a 32-bit build, because it had
already overwritten $serialno with something inappropriate
to use in the eventual match. We could go back to the
previous code layout, but it seems best to introduce a
separate variable for the output of openssl.
Per failure on buildfarm member mamba, which has a 32-bit Perl.
Branch
------
REL_18_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/399a9e04e5491f8a76ffb482f4a86b9acb6f91fb
Modified Files
--------------
src/test/ssl/t/001_ssltests.pl | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Fix thinko in commit 7d129ba54.
@ 2025-10-20 12:46 Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 5+ messages in thread
From: Tom Lane @ 2025-10-20 12:46 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix thinko in commit 7d129ba54.
The revised logic in 001_ssltests.pl would fail if openssl
doesn't work or if Perl is a 32-bit build, because it had
already overwritten $serialno with something inappropriate
to use in the eventual match. We could go back to the
previous code layout, but it seems best to introduce a
separate variable for the output of openssl.
Per failure on buildfarm member mamba, which has a 32-bit Perl.
Branch
------
REL_17_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/2fa8f94db1c36ad3774f7e16fe8381ceeb9c4081
Modified Files
--------------
src/test/ssl/t/001_ssltests.pl | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Fix thinko in commit 7d129ba54.
@ 2025-10-20 12:46 Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 5+ messages in thread
From: Tom Lane @ 2025-10-20 12:46 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix thinko in commit 7d129ba54.
The revised logic in 001_ssltests.pl would fail if openssl
doesn't work or if Perl is a 32-bit build, because it had
already overwritten $serialno with something inappropriate
to use in the eventual match. We could go back to the
previous code layout, but it seems best to introduce a
separate variable for the output of openssl.
Per failure on buildfarm member mamba, which has a 32-bit Perl.
Branch
------
REL_16_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/f1e1db780e50f9723edf67c52a7920e09c4dab40
Modified Files
--------------
src/test/ssl/t/001_ssltests.pl | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2025-10-21 13:19 UTC | newest]
Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-10-20 12:46 pgsql: Fix thinko in commit 7d129ba54. Tom Lane <tgl@sss.pgh.pa.us>
2025-10-21 13:19 ` Daniel Gustafsson <daniel@yesql.se>
2025-10-20 12:46 pgsql: Fix thinko in commit 7d129ba54. Tom Lane <tgl@sss.pgh.pa.us>
2025-10-20 12:46 pgsql: Fix thinko in commit 7d129ba54. Tom Lane <tgl@sss.pgh.pa.us>
2025-10-20 12:46 pgsql: Fix thinko in commit 7d129ba54. Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox