pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Fujii Masao <fujii@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Add comments explaining overflow entries in the replication lag
Date: Thu, 23 Oct 2025 04:27:25 +0000
Message-ID: <E1vBmv7-00347u-2N@gemulon.postgresql.org> (raw)

Add comments explaining overflow entries in the replication lag tracker.

Commit 883a95646a8 introduced overflow entries in the replication lag tracker
to fix an issue where lag columns in pg_stat_replication could stall when
the replay LSN stopped advancing.

This commit adds comments clarifying the purpose and behavior of overflow
entries to improve code readability and understanding.

Since commit 883a95646a8 was recently applied and backpatched to all
supported branches, this follow-up commit is also backpatched accordingly.

Author: Xuneng Zhou <xunengzhou@gmail.com>
Reviewed-by: Fujii Masao <masao.fujii@gmail.com>
Discussion: https://postgr.es/m/CABPTF7VxqQA_DePxyZ7Y8V+ErYyXkmwJ1P6NC+YC+cvxMipWKw@mail.gmail.com
Backpatch-through: 13

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/abc2b71383b4c49c2fbda74c281d50f3936551b8

Modified Files
--------------
src/backend/replication/walsender.c | 13 +++++++++++++
1 file changed, 13 insertions(+)



view thread (7+ messages)  latest in thread

Message-ID: <E1vBmv7-00347u-2N@gemulon.postgresql.org>
Permalink:  ../E1vBmv7-00347u-2N@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1vBmv7-00347u-2N@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: fujii@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Add comments explaining overflow entries in the replication lag
  In-Reply-To: <E1vBmv7-00347u-2N@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox