From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pg_rewind: Skip copy of WAL segments generated before point of d
Date: Sat, 25 Oct 2025 00:10:24 +0000
Message-ID: <E1vCRrU-003MGe-2d@gemulon.postgresql.org> (raw)
pg_rewind: Skip copy of WAL segments generated before point of divergence
This commit makes the way WAL segments are handled from the source to
the target server slightly smarter: the copy of the WAL segments is now
skipped if these have been created before the point where source and
target have diverged (the WAL segment where the point of divergence
exists is still copied), because we know that such segments exist on
both the target and source. Note that the on-disk size of the WAL
segments on the source and target need to match. Hence, only the
segments generated after the point of divergence are now copied. A
segment existing on the source but not the target is copied.
Previously, all the WAL segments were just copied in full. This change
can make the rewind operation cheaper in some configurations, especially
for setups where some WAL retention causes many segments to remain on
the source server even after the promotion of a standby used as source
to rewind a previous primary.
A TAP test is added to track these new behaviors. The file map printed
with --debug now includes all the information related to WAL segments,
to be able to track if these are copied or skipped, and the test relies
on the debug output generated.
Author: John Hsu <johnhyvr@gmail.com>
Author: Justin Kwan <justinpkwan@outlook.com>
Reviewed-by: Robert Haas <robertmhaas@gmail.com>
Reviewed-by: Alexander Korotkov <aekorotkov@gmail.com>
Reviewed-by: Japin Li <japinli@hotmail.com>
Reviewed-by: Michael Paquier <michael@paquier.xyz>
Reviewed-by: Srinath Reddy Sadipiralla <srinath2133@gmail.com>
Discussion: https://postgr.es/m/181b4c6fa9c.b8b725681941212.7547232617810891479@viggy28.dev
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/5173bfd0443e0c0f3fa37006727d516dc1ba4cee
Modified Files
--------------
doc/src/sgml/ref/pg_rewind.sgml | 32 ++++++++--
src/bin/pg_rewind/filemap.c | 55 ++++++++++++++--
src/bin/pg_rewind/filemap.h | 3 +-
src/bin/pg_rewind/meson.build | 1 +
src/bin/pg_rewind/pg_rewind.c | 9 ++-
src/bin/pg_rewind/t/011_wal_copy.pl | 122 ++++++++++++++++++++++++++++++++++++
6 files changed, 209 insertions(+), 13 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: pg_rewind: Skip copy of WAL segments generated before point of d
In-Reply-To: <E1vCRrU-003MGe-2d@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox