pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Simplify newline handling in two TAP tests
Date: Mon, 27 Oct 2025 23:27:32 +0000
Message-ID: <E1vDWce-003pjA-2e@gemulon.postgresql.org> (raw)

Simplify newline handling in two TAP tests

Two tests are changed in this commit:
- libpq's 006_service
- ldap's 003_ldap_connection_param_lookup

CRLF translation is already handled by the text mode, so there should be
need for any specific logic.  See also 1c6d4629394d, msys perl being one
case where the translation mattered.

Note: This is first applied on HEAD, and backpatch will follow once the
buildfarm has provided an opinion about this commit.

Author: Jacob Champion <jacob.champion@enterprisedb.com>
Co-authored-by: Michael Paquier <michael@paquier.xyz>
Reviewed-by: Daniel Gustafsson <daniel@yesql.se>
Discussion: https://postgr.es/m/aPsh39bxwYKvUlAf@paquier.xyz
Backpatch-through: 13

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/8767b449a3a1e75626dfb08f24da54933171d4c5

Modified Files
--------------
src/interfaces/libpq/t/006_service.pl              | 12 ++----
.../ldap/t/003_ldap_connection_param_lookup.pl     | 43 ++++++++--------------
2 files changed, 20 insertions(+), 35 deletions(-)



Message-ID: <E1vDWce-003pjA-2e@gemulon.postgresql.org>
Permalink:  ../E1vDWce-003pjA-2e@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1vDWce-003pjA-2e@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Simplify newline handling in two TAP tests
  In-Reply-To: <E1vDWce-003pjA-2e@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox