From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Simplify newline handling in libpq TAP test
Date: Wed, 29 Oct 2025 00:58:47 +0000
Message-ID: <E1vDuWV-0040GI-06@gemulon.postgresql.org> (raw)
Simplify newline handling in libpq TAP test
CRLF translation is already handled by the text mode, so there should be
no need for any specific logic. See also 1c6d4629394d, msys perl being
one case where the translation mattered.
Note: An equivalent has been first applied on HEAD with 8767b449a3a1.
The same change is backpatched to v18 as all the Windows buildfarm
members have reported green.
Author: Jacob Champion <jacob.champion@enterprisedb.com>
Co-authored-by: Michael Paquier <michael@paquier.xyz>
Reviewed-by: Daniel Gustafsson <daniel@yesql.se>
Discussion: https://postgr.es/m/aPsh39bxwYKvUlAf@paquier.xyz
Backpatch-through: 18
Branch
------
REL_18_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/a92bbffbc3a7157b0998f0423cf2304c81626822
Modified Files
--------------
src/interfaces/libpq/t/006_service.pl | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Simplify newline handling in libpq TAP test
In-Reply-To: <E1vDuWV-0040GI-06@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox