pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Add assertions checking for the startup process in WAL replay ro
Date: Wed, 05 Nov 2025 01:43:12 +0000
Message-ID: <E1vGSYK-005519-2n@gemulon.postgresql.org> (raw)

Add assertions checking for the startup process in WAL replay routines

These assertions may prove to become useful to make sure that no process
other than the startup process calls the routines where these checks are
added, as we expect that these do not interfere with a WAL receiver
switched to a "stopping" state by a startup process.

The assumption that only the startup process can use this code has
existed for many years, without a check enforcing it.

Reviewed-by: Xuneng Zhou <xunengzhou@gmail.com>
Discussion: https://postgr.es/m/aQmGeVLYl51y1m_0@paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2fc31079624e16d6b1a8508958dbf81e8edce057

Modified Files
--------------
src/backend/access/transam/xlog.c         | 2 ++
src/backend/access/transam/xlogrecovery.c | 4 ++++
2 files changed, 6 insertions(+)



Message-ID: <E1vGSYK-005519-2n@gemulon.postgresql.org>
Permalink:  ../E1vGSYK-005519-2n@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1vGSYK-005519-2n@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Add assertions checking for the startup process in WAL replay ro
  In-Reply-To: <E1vGSYK-005519-2n@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox