pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Etsuro Fujita <efujita@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: postgres_fdw: Add more test coverage for EvalPlanQual testing.
Date: Thu, 06 Nov 2025 03:17:23 +0000
Message-ID: <E1vGqV1-005ENx-25@gemulon.postgresql.org> (raw)

postgres_fdw: Add more test coverage for EvalPlanQual testing.

postgres_fdw supports EvalPlanQual testing by using the infrastructure
provided by the core with the RecheckForeignScan callback routine (cf.
commits 5fc4c26db and 385f337c9), but there has been no test coverage
for that, except that recent commit 12609fbac, which fixed an issue in
commit 385f337c9, added a test case to exercise only a code path added
by that commit to the core infrastructure.  So let's add test cases to
exercise other code paths as well at this time.

Like commit 12609fbac, back-patch to all supported branches.

Reported-by: Masahiko Sawada <sawada.mshk@gmail.com>
Author: Etsuro Fujita <etsuro.fujita@gmail.com>
Discussion: https://postgr.es/m/CAPmGK15%2B6H%3DkDA%3D-y3Y28OAPY7fbAdyMosVofZZ%2BNc769epVTQ%40mail.gmail.com
Backpatch-through: 13

Branch
------
REL_17_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/e1445d1bf718ec38da986f5d41de91f030df6d01

Modified Files
--------------
contrib/postgres_fdw/expected/eval_plan_qual.out | 108 +++++++++++++++++++++--
contrib/postgres_fdw/specs/eval_plan_qual.spec   |  61 +++++++++++--
2 files changed, 155 insertions(+), 14 deletions(-)



view thread (7+ messages)  latest in thread

Message-ID: <E1vGqV1-005ENx-25@gemulon.postgresql.org>
Permalink:  ../E1vGqV1-005ENx-25@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1vGqV1-005ENx-25@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: efujita@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: postgres_fdw: Add more test coverage for EvalPlanQual testing.
  In-Reply-To: <E1vGqV1-005ENx-25@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox