pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Add check for large files in meson.build
Date: Wed, 12 Nov 2025 00:03:03 +0000
Message-ID: <E1vIyKF-0068w9-37@gemulon.postgresql.org> (raw)

Add check for large files in meson.build

A similar check existed in the MSVC scripts that have been removed in
v17 by 1301c80b2167, but nothing of the kind was checked in meson when
building with a 4-byte off_t.

This commit adds a check to fail the builds when trying to use a
relation file size higher than 1GB when off_t is 4 bytes, like
./configure, rather than detecting these failures at runtime because the
code is not able to handle large files in this case.

Backpatch down to v16, where meson has been introduced.

Discussion: https://postgr.es/m/aQ0hG36IrkaSGfN8@paquier.xyz
Backpatch-through: 16

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/79cd66f28c65abbdc0ed695a9583a530fe6ece14

Modified Files
--------------
meson.build | 8 ++++++++
1 file changed, 8 insertions(+)



view thread (4+ messages)  latest in thread

Message-ID: <E1vIyKF-0068w9-37@gemulon.postgresql.org>
Permalink:  ../E1vIyKF-0068w9-37@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1vIyKF-0068w9-37@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Add check for large files in meson.build
  In-Reply-To: <E1vIyKF-0068w9-37@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox