pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix pg_crc32c_armv8_choose.c to build with ancient glibc release
Date: Mon, 17 Nov 2025 20:24:48 +0000
Message-ID: <E1vL5mK-0002qc-1J@gemulon.postgresql.org> (raw)

Fix pg_crc32c_armv8_choose.c to build with ancient glibc releases.

If you go back as far as the RHEL7 era, <sys/auxv.h> does not provide
the HWCAPxxx macros needed with elf_aux_info or getauxval, so you need
to get those from the kernel header <asm/hwcap.h> instead.  We knew
that for the 32-bit case but failed to extrapolate to the 64-bit case.
Oversight in commit aac831caf.

Reported-by: GaoZengqi <pgf00a@gmail.com>
Author: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/CAFmBtr3Av62-jBzdhFkDHXJF9vQmNtSnH2upwODjnRcsgdTytw@mail.gmail.com
Backpatch-through: 18

Branch
------
REL_18_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/db4eba15266e4f78aa62fd1444f3e858a284c686

Modified Files
--------------
src/port/pg_crc32c_armv8_choose.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)



view thread (2+ messages)  latest in thread

Message-ID: <E1vL5mK-0002qc-1J@gemulon.postgresql.org>
Permalink:  ../E1vL5mK-0002qc-1J@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1vL5mK-0002qc-1J@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix pg_crc32c_armv8_choose.c to build with ancient glibc release
  In-Reply-To: <E1vL5mK-0002qc-1J@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox