pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Amit Langote <amitlan@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix error reporting for SQL/JSON path type mismatches
Date: Thu, 27 Nov 2025 03:12:26 +0000
Message-ID: <E1vOSQj-001avh-1r@gemulon.postgresql.org> (raw)

Fix error reporting for SQL/JSON path type mismatches

transformJsonFuncExpr() used exprType()/exprLocation() on the
possibly coerced path expression, which could be NULL when
coercion to jsonpath failed, leading to "cache lookup failed
for type 0" errors.

Preserve the original expression node so that type and location
in the "must be of type jsonpath" error are reported correctly.
Add regression tests to cover these cases.

Reported-by: Jian He <jian.universality@gmail.com>
Author: Jian He <jian.universality@gmail.com>
Reviewed-by: Kirill Reshke <reshkekirill@gmail.com>
Discussion: https://postgr.es/m/CACJufxHunVg81JMuNo8Yvv_hJD0DicgaVN2Wteu8aJbVJPBjZA@mail.gmail.com
Backpatch-through: 17

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/519fa0433b37701b357753a568080bee2c47d238

Modified Files
--------------
src/backend/parser/parse_expr.c                  | 23 +++++++++++++++--------
src/test/regress/expected/sqljson_queryfuncs.out |  8 ++++++++
src/test/regress/sql/sqljson_queryfuncs.sql      |  2 ++
3 files changed, 25 insertions(+), 8 deletions(-)



view thread (3+ messages)

Message-ID: <E1vOSQj-001avh-1r@gemulon.postgresql.org>
Permalink:  ../E1vOSQj-001avh-1r@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1vOSQj-001avh-1r@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: amitlan@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix error reporting for SQL/JSON path type mismatches
  In-Reply-To: <E1vOSQj-001avh-1r@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox