pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Switch some date/timestamp functions to use the soft error repor
Date: Mon, 01 Dec 2025 06:22:44 +0000
Message-ID: <E1vPxJ5-002F0M-2z@gemulon.postgresql.org> (raw)

Switch some date/timestamp functions to use the soft error reporting

This commit changes some functions related to the data types date and
timestamp to use the soft error reporting rather than a custom boolean
flag called "overflow", used to let the callers of these functions know
if an overflow happens.

This results in the removal of some boilerplate code, as it is possible
to rely on an error context rather than a custom state, with the
possibility to use the error generated inside the functions updated
here, if necessary.

These functions were suffixed with "_opt_overflow".  They are now
renamed to use "_safe" as suffix.

This work is similar to 4246a977bad6.

Author: Amul Sul <sulamul@gmail.com>
Reviewed-by: Amit Langote <amitlangote09@gmail.com>
Reviewed-by: Michael Paquier <michael@paquier.xyz>
Discussion: https://postgr.es/m/CAAJ_b95HEmFyzHZfsdPquSHeswcopk8MCG1Q_vn4tVkZ+xxofw@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d03668ea0566b53522cf2628ab7aa630247640a4

Modified Files
--------------
contrib/btree_gin/btree_gin.c |  25 ++---
src/backend/utils/adt/date.c  | 209 ++++++++++++++++--------------------------
src/include/utils/date.h      |   8 +-
3 files changed, 96 insertions(+), 146 deletions(-)



Message-ID: <E1vPxJ5-002F0M-2z@gemulon.postgresql.org>
Permalink:  ../E1vPxJ5-002F0M-2z@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1vPxJ5-002F0M-2z@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Switch some date/timestamp functions to use the soft error repor
  In-Reply-To: <E1vPxJ5-002F0M-2z@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox