From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Move WAL sequence code into its own file
Date: Mon, 01 Dec 2025 07:22:34 +0000
Message-ID: <E1vPyF0-002FTA-1W@gemulon.postgresql.org> (raw)
Move WAL sequence code into its own file
This split exists for most of the other RMGRs, and makes cleaner the
separation between the WAL code, the redo code and the record
description code (already in its own file) when it comes to the sequence
RMGR. The redo and masking routines are moved to a new file,
sequence_xlog.c. All the RMGR routines are now located in a new header,
sequence_xlog.h.
This separation is useful for a different patch related to sequences
that I have been working on, where it makes a refactoring of sequence.c
easier if its RMGR routines and its core routines are split.
Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi>
Reviewed-by: Kirill Reshke <reshkekirill@gmail.com>
Discussion: https://postgr.es/m/aSfTxIWjiXkTKh1E@paquier.xyz
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/a87987cafca683e9076c424f99bae117211a83a4
Modified Files
--------------
src/backend/access/rmgrdesc/seqdesc.c | 2 +-
src/backend/access/transam/rmgr.c | 2 +-
src/backend/commands/Makefile | 1 +
src/backend/commands/meson.build | 1 +
src/backend/commands/sequence.c | 76 +--------------------------------
src/backend/commands/sequence_xlog.c | 80 +++++++++++++++++++++++++++++++++++
src/bin/pg_waldump/rmgrdesc.c | 2 +-
src/include/commands/sequence.h | 18 --------
src/include/commands/sequence_xlog.h | 45 ++++++++++++++++++++
9 files changed, 132 insertions(+), 95 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Move WAL sequence code into its own file
In-Reply-To: <E1vPyF0-002FTA-1W@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox