From: Melanie Plageman <melanieplageman@gmail.com>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Suppress spurious Coverity warning in prune freeze logic
Date: Thu, 04 Dec 2025 23:56:29 +0000
Message-ID: <E1vRJBU-002qc3-1p@gemulon.postgresql.org> (raw)
Suppress spurious Coverity warning in prune freeze logic
Adjust the prune_freeze_setup() parameter types of new_relfrozen_xid and
new_relmin_mxid to prevent misleading Coverity analysis.
heap_page_prune_and_freeze() compared these values against NULL when
passing them to prune_freeze_setup(), causing Coverity to assume they
could be NULL and flag a possible null-pointer dereference later, even
though it occurs inside a directly related conditional.
Reported-by: Coverity
Author: Melanie Plageman <melanieplageman@gmail.com>
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/904f9f5ea0e00a88e2429682d01f2ec946bf553a
Modified Files
--------------
src/backend/access/heap/pruneheap.c | 28 ++++++++++++----------------
1 file changed, 12 insertions(+), 16 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: melanieplageman@gmail.com, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Suppress spurious Coverity warning in prune freeze logic
In-Reply-To: <E1vRJBU-002qc3-1p@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox