pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix some compiler warnings
Date: Fri, 05 Dec 2025 03:31:29 +0000
Message-ID: <E1vRMXZ-002sEJ-0O@gemulon.postgresql.org> (raw)

Fix some compiler warnings

Some of the buildfarm members with some old gcc versions have been
complaining about an always-true test for a NULL pointer caused by a
combination of SOFT_ERROR_OCCURRED() and a local ErrorSaveContext
variable.

These warnings are taken care of by removing SOFT_ERROR_OCCURRED(),
switching to a direct variable check, like 56b1e88c804b.

Oversights in e1405aa5e3ac and 44eba8f06e55.

Reported-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/1341064.1764895052@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/7bc88c3d6f3af3af5330c0e209c8a3c411267d00

Modified Files
--------------
src/backend/utils/adt/pg_dependencies.c | 6 +++---
src/backend/utils/adt/pg_ndistinct.c    | 4 ++--
2 files changed, 5 insertions(+), 5 deletions(-)



Message-ID: <E1vRMXZ-002sEJ-0O@gemulon.postgresql.org>
Permalink:  ../E1vRMXZ-002sEJ-0O@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1vRMXZ-002sEJ-0O@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix some compiler warnings
  In-Reply-To: <E1vRMXZ-002sEJ-0O@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox