pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Improve test output of extended statistics for ndistinct and dep
Date: Fri, 05 Dec 2025 05:16:17 +0000
Message-ID: <E1vROAy-002syD-1w@gemulon.postgresql.org> (raw)

Improve test output of extended statistics for ndistinct and dependencies

Corey Huinker has come up with a recipe that is more compact and more
pleasant to the eye for extended stats because we know that all of them
are 1-dimension JSON arrays.  This commit switches the extended stats
tests to use replace() instead of jsonb_pretty(), splitting the data so
as one line is used for each item in the extended stats object.

This results in the removal of a good chunk of test output, that is now
easier to debug with one line used for each item in a stats object.
This patch has not been provided by Corey.  This is some post-commit
cleanup work that I have noticed as good enough to do on its own while
reviewing the rest of the patch set Corey has posted.

Discussion: https://postgr.es/m/CADkLM=csMd52i39Ye8-PUUHyzBb3546eSCUTh-FBQ7bzT2uZ4Q@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2f04110225ab30fbd9889d6f5d73fd6b3e1b308b

Modified Files
--------------
src/test/regress/expected/stats_ext.out | 272 ++++++--------------------------
src/test/regress/sql/stats_ext.sql      |  20 +--
2 files changed, 60 insertions(+), 232 deletions(-)



Message-ID: <E1vROAy-002syD-1w@gemulon.postgresql.org>
Permalink:  ../E1vROAy-002syD-1w@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1vROAy-002syD-1w@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Improve test output of extended statistics for ndistinct and dep
  In-Reply-To: <E1vROAy-002syD-1w@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox