From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Improve error messages of input functions for pg_dependencies an
Date: Mon, 08 Dec 2025 01:24:19 +0000
Message-ID: <E1vSPz8-003LrJ-1m@gemulon.postgresql.org> (raw)
Improve error messages of input functions for pg_dependencies and pg_ndistinct
The error details updated in this commit can be reached in the
regression tests. They did not follow the project style, and they
should be written them as full sentences.
Some of the errors are switched to use an elog(), for cases that involve
paths that cannot be reached based on the previous state of the parser
processing the input data (array start, object end, etc.). The error
messages for these cases use now a more consistent style across the
board, with the state of the parser reported for debugging.
Reported-by: Tom Lane <tgl@sss.pgh.pa.us>
Author: Michael Paquier <michael@paquier.xyz>
Co-authored-by: Corey Huinker <corey.huinker@gmail.com>
Discussion: https://postgr.es/m/1353179.1764901790@sss.pgh.pa.us
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/f68597ee777d0a177e84cf86b8386ea51c66b52e
Modified Files
--------------
src/backend/utils/adt/pg_dependencies.c | 59 ++++----
src/backend/utils/adt/pg_ndistinct.c | 53 +++----
src/test/regress/expected/pg_dependencies.out | 196 +++++++++++++-------------
src/test/regress/expected/pg_ndistinct.out | 160 ++++++++++-----------
4 files changed, 227 insertions(+), 241 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Improve error messages of input functions for pg_dependencies an
In-Reply-To: <E1vSPz8-003LrJ-1m@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox