From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: injection_points: Remove portions related to custom pgstats
Date: Mon, 08 Dec 2025 03:46:34 +0000
Message-ID: <E1vSSCn-003N0Z-2i@gemulon.postgresql.org> (raw)
injection_points: Remove portions related to custom pgstats
The test module injection_points has been used as a landing spot to
provide coverage for the custom pgstats APIs, for both fixed-sized and
variable-sized stats kinds. Some recent work related to pgstats is
proving that this structure makes the implementation of new tests
harder.
This commit removes the code related to pgstats from injection_points,
and an equivalent will be reintroduced as a separate test module in a
follow-up commit. This removal is done in its own commit for clarity.
Using injection_points for this test coverage was perhaps not the best
way to design things, but this was good enough while working on the
first flavor of the custom pgstats APIs. Using a new test module will
make easier the introduction of new tests, and we will not need to worry
about the impact of new changes related to custom pgstats could have
with the internals of injection_points.
Author: Sami Imseih <samimseih@gmail.com>
Discussion: https://postgr.es/m/CAA5RZ0sJgO6GAwgFxmzg9MVP=rM7Us8KKcWpuqxe-f5qxmpE0g@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/d52c24b0f808a6644fd839c507625eafd6bb9f12
Modified Files
--------------
doc/src/sgml/xfunc.sgml | 6 -
src/test/modules/injection_points/Makefile | 4 -
.../injection_points/injection_points--1.0.sql | 43 ----
.../modules/injection_points/injection_points.c | 48 -----
.../modules/injection_points/injection_stats.c | 228 ---------------------
.../modules/injection_points/injection_stats.h | 35 ----
.../injection_points/injection_stats_fixed.c | 214 -------------------
src/test/modules/injection_points/meson.build | 12 --
src/test/modules/injection_points/t/001_stats.pl | 103 ----------
src/tools/pgindent/typedefs.list | 4 -
10 files changed, 697 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: injection_points: Remove portions related to custom pgstats
In-Reply-To: <E1vSSCn-003N0Z-2i@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox