From: Heikki Linnakangas <heikki.linnakangas@iki.fi>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pg_resetwal: Use separate flags for whether an option is given
Date: Mon, 08 Dec 2025 14:56:17 +0000
Message-ID: <E1vSceu-003Rvm-1g@gemulon.postgresql.org> (raw)
pg_resetwal: Use separate flags for whether an option is given
Currently, we use special values that are otherwise invalid for each
option to indicate "option was not given". Replace that with separate
boolean variables for each option. It seems more clear to be explicit.
We were already doing that for the -m option, because there were no
invalid values for nextMulti that we could use (since commit
94939c5f3a).
Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Discussion: https://www.postgresql.org/message-id/81adf5f3-36ad-4bcd-9ba5-1b95c7b7a807@iki.fi
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/978cf02bb8caeafd6fe5178e67016ffd898599b4
Modified Files
--------------
src/bin/pg_resetwal/pg_resetwal.c | 166 ++++++++++++++++++++++----------------
1 file changed, 95 insertions(+), 71 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: heikki.linnakangas@iki.fi, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: pg_resetwal: Use separate flags for whether an option is given
In-Reply-To: <E1vSceu-003Rvm-1g@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox