pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Heikki Linnakangas <heikki.linnakangas@iki.fi>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix some near-bugs related to ResourceOwner function arguments
Date: Wed, 10 Dec 2025 09:50:52 +0000
Message-ID: <E1vTGqS-003n5S-1C@gemulon.postgresql.org> (raw)

Fix some near-bugs related to ResourceOwner function arguments

These functions took a ResourceOwner argument, but only checked if it
was NULL, and then used CurrentResourceOwner for the actual work.
Surely the intention was to use the passed-in resource owner. All
current callers passed CurrentResourceOwner or NULL, so this has no
consequences at the moment, but it's an accident waiting to happen for
future caller and extensions.

Author: Matthias van de Meent <boekewurm+postgres@gmail.com>
Discussion: https://www.postgresql.org/message-id/CAEze2Whnfv8VuRZaohE-Af+GxBA1SNfD_rXfm84Jv-958UCcJA@mail.gmail...
Backpatch-through: 17

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/fa44b8b7fbb7eb0f13546aa13976f9919a4ca201

Modified Files
--------------
src/backend/storage/aio/aio.c      | 12 ++++++------
src/backend/utils/cache/catcache.c |  4 ++--
2 files changed, 8 insertions(+), 8 deletions(-)



view thread (3+ messages)  latest in thread

Message-ID: <E1vTGqS-003n5S-1C@gemulon.postgresql.org>
Permalink:  ../E1vTGqS-003n5S-1C@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1vTGqS-003n5S-1C@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: heikki.linnakangas@iki.fi, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix some near-bugs related to ResourceOwner function arguments
  In-Reply-To: <E1vTGqS-003n5S-1C@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox