pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix some near-bugs related to ResourceOwner function arguments 3+ messages / 1 participants [nested] [flat]
* pgsql: Fix some near-bugs related to ResourceOwner function arguments @ 2025-12-10 09:50 Heikki Linnakangas <heikki.linnakangas@iki.fi> 0 siblings, 0 replies; 3+ messages in thread From: Heikki Linnakangas @ 2025-12-10 09:50 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix some near-bugs related to ResourceOwner function arguments These functions took a ResourceOwner argument, but only checked if it was NULL, and then used CurrentResourceOwner for the actual work. Surely the intention was to use the passed-in resource owner. All current callers passed CurrentResourceOwner or NULL, so this has no consequences at the moment, but it's an accident waiting to happen for future caller and extensions. Author: Matthias van de Meent <boekewurm+postgres@gmail.com> Discussion: https://www.postgresql.org/message-id/CAEze2Whnfv8VuRZaohE-Af+GxBA1SNfD_rXfm84Jv-958UCcJA@mail.gmail... Backpatch-through: 17 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/fa44b8b7fbb7eb0f13546aa13976f9919a4ca201 Modified Files -------------- src/backend/storage/aio/aio.c | 12 ++++++------ src/backend/utils/cache/catcache.c | 4 ++-- 2 files changed, 8 insertions(+), 8 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Fix some near-bugs related to ResourceOwner function arguments @ 2025-12-10 09:50 Heikki Linnakangas <heikki.linnakangas@iki.fi> 0 siblings, 0 replies; 3+ messages in thread From: Heikki Linnakangas @ 2025-12-10 09:50 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix some near-bugs related to ResourceOwner function arguments These functions took a ResourceOwner argument, but only checked if it was NULL, and then used CurrentResourceOwner for the actual work. Surely the intention was to use the passed-in resource owner. All current callers passed CurrentResourceOwner or NULL, so this has no consequences at the moment, but it's an accident waiting to happen for future caller and extensions. Author: Matthias van de Meent <boekewurm+postgres@gmail.com> Discussion: https://www.postgresql.org/message-id/CAEze2Whnfv8VuRZaohE-Af+GxBA1SNfD_rXfm84Jv-958UCcJA@mail.gmail... Backpatch-through: 17 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/e8dc5810a227d5671c25dc2c7dbe1321093a08a6 Modified Files -------------- src/backend/storage/aio/aio.c | 12 ++++++------ src/backend/utils/cache/catcache.c | 4 ++-- 2 files changed, 8 insertions(+), 8 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Fix some near-bugs related to ResourceOwner function arguments @ 2025-12-10 09:50 Heikki Linnakangas <heikki.linnakangas@iki.fi> 0 siblings, 0 replies; 3+ messages in thread From: Heikki Linnakangas @ 2025-12-10 09:50 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix some near-bugs related to ResourceOwner function arguments These functions took a ResourceOwner argument, but only checked if it was NULL, and then used CurrentResourceOwner for the actual work. Surely the intention was to use the passed-in resource owner. All current callers passed CurrentResourceOwner or NULL, so this has no consequences at the moment, but it's an accident waiting to happen for future caller and extensions. Author: Matthias van de Meent <boekewurm+postgres@gmail.com> Discussion: https://www.postgresql.org/message-id/CAEze2Whnfv8VuRZaohE-Af+GxBA1SNfD_rXfm84Jv-958UCcJA@mail.gmail... Backpatch-through: 17 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/998d100cdb7220a81b8775b67fbc1d5bbb918052 Modified Files -------------- src/backend/utils/cache/catcache.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2025-12-10 09:50 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-12-10 09:50 pgsql: Fix some near-bugs related to ResourceOwner function arguments Heikki Linnakangas <heikki.linnakangas@iki.fi> 2025-12-10 09:50 pgsql: Fix some near-bugs related to ResourceOwner function arguments Heikki Linnakangas <heikki.linnakangas@iki.fi> 2025-12-10 09:50 pgsql: Fix some near-bugs related to ResourceOwner function arguments Heikki Linnakangas <heikki.linnakangas@iki.fi>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox