From: Heikki Linnakangas <heikki.linnakangas@iki.fi>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Improve DDL deparsing test
Date: Wed, 10 Dec 2025 17:32:12 +0000
Message-ID: <E1vTO2t-0000ld-0Y@gemulon.postgresql.org> (raw)
Improve DDL deparsing test
1. The test initially focuses on the "parent" table, then switches to
the "part" table, and goes back to the "parent" table. That seems a
little weird, so move the tests around so that all the commands on the
"parent" table are done first, followed by the "part" table.
2. ALTER TABLE ALTER COLUMN SET EXPRESSION was not tested, so add
that.
Author: jian he <jian.universality@gmail.com>
Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Discussion: https://www.postgresql.org/message-id/CACJufxFDi7fnwB-8xXd_ExML7-7pKbTaK4j46AJ=4-14DXvtVg@mail.gmail...
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/343693c3c116688970be550fcbf15f7ddf55525b
Modified Files
--------------
.../test_ddl_deparse/expected/alter_table.out | 41 ++++++++++++----------
.../modules/test_ddl_deparse/sql/alter_table.sql | 27 +++++++-------
2 files changed, 36 insertions(+), 32 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: heikki.linnakangas@iki.fi, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Improve DDL deparsing test
In-Reply-To: <E1vTO2t-0000ld-0Y@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox