pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Looks like we can't test NLS on machines that lack any es_ES loc
Date: Sun, 14 Dec 2025 19:31:16 +0000
Message-ID: <E1vUroJ-000ldr-2J@gemulon.postgresql.org> (raw)

Looks like we can't test NLS on machines that lack any es_ES locale.

While commit 5b275a6e1 fixed a few unhappy buildfarm animals,
it looks like the remainder simply don't have any es_ES locale
at all.  There's little point in running the test in that case,
so minimize the number of variant expected-files by bailing out.
Also emit a log entry so that it's possible to tell from buildfarm
postmaster logs which case occurred.

Possibly, the scope of this testing could be improved by providing
additional translations.  But I think it's likely that the failing
animals have no non-C locales installed at all.

In passing, update typedefs.list so that koel doesn't think
regress.c is misformatted.

Discussion: https://postgr.es/m/E1vUpNU-000kcQ-1D@gemulon.postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/fe7ede45f125af271fb3fef3cc5ee507d4c40d87

Modified Files
--------------
src/test/regress/expected/nls.out   | 10 ++++++++++
src/test/regress/expected/nls_1.out | 10 ++++++++++
src/test/regress/expected/nls_2.out | 35 +++++++++++++++++++++++++++++++++++
src/test/regress/sql/nls.sql        | 12 ++++++++++++
src/tools/pgindent/typedefs.list    |  2 ++
5 files changed, 69 insertions(+)



Message-ID: <E1vUroJ-000ldr-2J@gemulon.postgresql.org>
Permalink:  ../E1vUroJ-000ldr-2J@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1vUroJ-000ldr-2J@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Looks like we can't test NLS on machines that lack any es_ES loc
  In-Reply-To: <E1vUroJ-000ldr-2J@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox