pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Noah Misch <noah@leadboat.com>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Revisit cosmetics of "For inplace update, send nontransactional
Date: Mon, 15 Dec 2025 20:21:26 +0000
Message-ID: <E1vVF4P-000xgZ-0N@gemulon.postgresql.org> (raw)

Revisit cosmetics of "For inplace update, send nontransactional invalidations."

This removes a never-used CacheInvalidateHeapTupleInplace() parameter.
It adds README content about inplace update visibility in logical
decoding.  It rewrites other comments.

Back-patch to v18, where commit 243e9b40f1b2dd09d6e5bf91ebf6e822a2cd3704
first appeared.  Since this removes a CacheInvalidateHeapTupleInplace()
parameter, expect a v18 ".abi-compliance-history" edit to follow.  PGXN
contains no calls to that function.

Reported-by: Paul A Jungwirth <pj@illuminatedcomputing.com>
Reported-by: Ilyasov Ian <ianilyasov@outlook.com>
Reviewed-by: Paul A Jungwirth <pj@illuminatedcomputing.com>
Reviewed-by: Surya Poondla <s_poondla@apple.com>
Discussion: https://postgr.es/m/CA+renyU+LGLvCqS0=fHit-N1J-2=2_mPK97AQxvcfKm+F-DxJA@mail.gmail.com
Backpatch-through: 18

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/64bf53dd61ea3224020bb340725a4df6a27bc974

Modified Files
--------------
src/backend/access/heap/README.tuplock   | 32 ++++++++++++++++++++++++++++++++
src/backend/access/heap/heapam.c         | 30 ++++++++++++++----------------
src/backend/replication/logical/decode.c | 15 +++------------
src/backend/utils/cache/inval.c          | 10 +++++++---
src/include/utils/inval.h                |  3 +--
5 files changed, 57 insertions(+), 33 deletions(-)

view thread (2+ messages)

Message-ID: <E1vVF4P-000xgZ-0N@gemulon.postgresql.org>
Permalink:  ../E1vVF4P-000xgZ-0N@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1vVF4P-000xgZ-0N@gemulon.postgresql.org

copy link · copy postgr.es

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: noah@leadboat.com, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Revisit cosmetics of "For inplace update, send nontransactional
  In-Reply-To: <E1vVF4P-000xgZ-0N@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox