pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: libpq: Align oauth_json_set_error() with other NLS patterns 2+ messages / 1 participants [nested] [flat]
* pgsql: libpq: Align oauth_json_set_error() with other NLS patterns @ 2025-12-15 22:28 Jacob Champion <jchampion@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Jacob Champion @ 2025-12-15 22:28 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org libpq: Align oauth_json_set_error() with other NLS patterns Now that the prior commits have fixed missing OAuth translations, pull the bespoke usage of libpq_gettext() for OAUTHBEARER parsing into oauth_json_set_error() itself, and make that a gettext trigger as well, to better match what the other sites are doing. Add an _internal() variant to handle the existing untranslated case. Suggested-by: Daniel Gustafsson <daniel@yesql.se> Reviewed-by: Álvaro Herrera <alvherre@kurilemu.de> Discussion: https://postgr.es/m/0EEBCAA8-A5AC-4E3B-BABA-0BA7A08C361B%40yesql.se Backpatch-through: 18 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/f7fbd02d32c46ee1cada6c3faf94414657b7a19a Modified Files -------------- src/interfaces/libpq/fe-auth-oauth.c | 31 +++++++++++++++++++------------ src/interfaces/libpq/nls.mk | 2 ++ 2 files changed, 21 insertions(+), 12 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: libpq: Align oauth_json_set_error() with other NLS patterns @ 2025-12-15 22:28 Jacob Champion <jchampion@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Jacob Champion @ 2025-12-15 22:28 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org libpq: Align oauth_json_set_error() with other NLS patterns Now that the prior commits have fixed missing OAuth translations, pull the bespoke usage of libpq_gettext() for OAUTHBEARER parsing into oauth_json_set_error() itself, and make that a gettext trigger as well, to better match what the other sites are doing. Add an _internal() variant to handle the existing untranslated case. Suggested-by: Daniel Gustafsson <daniel@yesql.se> Reviewed-by: Álvaro Herrera <alvherre@kurilemu.de> Discussion: https://postgr.es/m/0EEBCAA8-A5AC-4E3B-BABA-0BA7A08C361B%40yesql.se Backpatch-through: 18 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/7a15cff1f11193467898da1c1fabf06fd2caee04 Modified Files -------------- src/interfaces/libpq/fe-auth-oauth.c | 31 +++++++++++++++++++------------ src/interfaces/libpq/nls.mk | 2 ++ 2 files changed, 21 insertions(+), 12 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2025-12-15 22:28 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-12-15 22:28 pgsql: libpq: Align oauth_json_set_error() with other NLS patterns Jacob Champion <jchampion@postgresql.org> 2025-12-15 22:28 pgsql: libpq: Align oauth_json_set_error() with other NLS patterns Jacob Champion <jchampion@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox